Commit 4ef6d6b1 authored by Daniel Stenberg's avatar Daniel Stenberg
Browse files

curl: glob_range: no need to check unsigned variable for negative 

cppcheck warned:

[src/tool_urlglob.c:283]: (style) Checking if unsigned variable 'step_n'
is less than zero.
parent 2ad3cf2f

src/tool_urlglob.c

+2 −3
Original line number Diff line number Diff line
@@ -5,7 +5,7 @@ 
 *                            | (__| |_| |  _ <| |___

 *                             \___|\___/|_| \_\_____|

 *

 * Copyright (C) 1998 - 2015, Daniel Stenberg, <daniel@haxx.se>, et al.

 * Copyright (C) 1998 - 2016, Daniel Stenberg, <daniel@haxx.se>, et al.

 *

 * This software is licensed as described in the file COPYING, which

 * you should have received as part of this distribution. The terms
@@ -279,8 +279,7 @@ static CURLcode glob_range(URLGlob *glob, char **patternp, 


    *posp += (pattern - *patternp);



    if(!endp || (min_n > max_n) || (step_n > (max_n - min_n)) ||

       (step_n <= 0) )

    if(!endp || (min_n > max_n) || (step_n > (max_n - min_n)) || !step_n)

      /* the pattern is not well-formed */

      return GLOBERROR("bad range", *posp, CURLE_URL_MALFORMAT);