Commit 36837c10 authored by Steve Holme's avatar Steve Holme
Browse files

smtp_doing: don't call smtp_dophase_done() if already failed 

Applied the POP3 fix from commit 2897ce7d so smtp_dophase_done()
isn't called if smtp_multi_statemach() fails.
parent f947de4b

lib/smtp.c

+6 −4
Original line number Diff line number Diff line
@@ -1591,11 +1591,13 @@ static CURLcode smtp_doing(struct connectdata *conn, bool *dophase_done) 


  if(result)

    DEBUGF(infof(conn->data, "DO phase failed\n"));

  else

    DEBUGF(infof(conn->data, "DO phase is complete\n"));

  else {

    if(*dophase_done) {

      result = smtp_dophase_done(conn, FALSE /* not connected */);



  if(*dophase_done)

    smtp_dophase_done(conn, FALSE /* not connected */);

      DEBUGF(infof(conn->data, "DO phase is complete\n"));

    }

  }



  return result;

}