Commit 2dded8fe authored by Daniel Stenberg's avatar Daniel Stenberg
Browse files

ossl_seed: no more RAND_screen 

RAND_screen() is slow, not thread-safe and not needed anymore since OpenSSL
uses the thread-safe win32 CryptoAPI nowadays.
parent be16b227

lib/ssluse.c

+2 −8
Original line number Diff line number Diff line
@@ -225,7 +225,8 @@ static int ossl_seed(struct SessionHandle *data) 
  /* If we get here, it means we need to seed the PRNG using a "silly"

     approach! */

#ifdef HAVE_RAND_SCREEN

  /* if RAND_screen() is present, it was called during global init */

  /* if RAND_screen() is present, this is windows and thus we assume that the

     randomness is already taken care of */

  nread = 100; /* just a value */

#else

  {
@@ -685,13 +686,6 @@ int Curl_ossl_init(void) 


  OpenSSL_add_all_algorithms();



#ifdef HAVE_RAND_SCREEN

  /* This one gets a random value by reading the currently shown screen.

     RAND_screen() is not thread-safe according to OpenSSL devs - although not

     mentioned in documentation. */

  RAND_screen();

#endif



  return 1;

}