WARNING! Gitlab maintenance operation scheduled for Monday, 20 April between 12:00 and 14:00 (CET). During this time window, short service interruptions (less than 5 minutes) may occur. Thank you in advance for your understanding.

Commit 2642638f authored Aug 01, 2009 by Daniel Stenberg

- Alexander Beedie provided the patch for a noproxy problem: If I have set

  CURLOPT_NOPROXY to "*", or to a host that should not use a proxy, I actually
  could still end up using a proxy if a proxy environment variable was set.

parent 8b0fc981

CHANGES

+5 −0

Original line number	Original line	Diff line number	Diff line
	@@ -6,6 +6,11 @@

	Changelog		Changelog

			Daniel Stenberg (1 Aug 2009)
			- Alexander Beedie provided the patch for a noproxy problem: If I have set
			CURLOPT_NOPROXY to "*", or to a host that should not use a proxy, I actually
			could still end up using a proxy if a proxy environment variable was set.

	Daniel Stenberg (27 Jul 2009)		Daniel Stenberg (27 Jul 2009)
	- All the quote options (CURLOPT_QUOTE, CURLOPT_POSTQUOTE and		- All the quote options (CURLOPT_QUOTE, CURLOPT_POSTQUOTE and
	CURLOPT_PREQUOTE) now accept a preceeding asterisk before the command to		CURLOPT_PREQUOTE) now accept a preceeding asterisk before the command to

RELEASE-NOTES

+2 −1

Original line number	Original line	Diff line number	Diff line
	@@ -38,6 +38,7 @@ This release includes the following bugfixes:
	o improved the support for client certificates in libcurl+NSS		o improved the support for client certificates in libcurl+NSS
	o fix leak in gtls code		o fix leak in gtls code
	o missing algorithms in libcurl+OpenSSL		o missing algorithms in libcurl+OpenSSL
			o with noproxy set you could still get a proxy if a proxy env was set

	This release includes the following known bugs:		This release includes the following known bugs:

	@@ -50,6 +51,6 @@ advice from friends like these:
	Andre Guibert de Bruet, Mike Crowe, Claes Jakobsson, John E. Malmberg,		Andre Guibert de Bruet, Mike Crowe, Claes Jakobsson, John E. Malmberg,
	Aaron Oneal, Igor Novoseltsev, Eric Wong, Bill Hoffman, Daniel Steinberg,		Aaron Oneal, Igor Novoseltsev, Eric Wong, Bill Hoffman, Daniel Steinberg,
	Fabian Keil, Michal Marek, Reuven Wachtfogel, Markus Koetter,		Fabian Keil, Michal Marek, Reuven Wachtfogel, Markus Koetter,
	Constantine Sapuntzakis, David Binderman, Johan van Selst		Constantine Sapuntzakis, David Binderman, Johan van Selst, Alexander Beedie

	Thanks! (and sorry if I forgot to mention someone)		Thanks! (and sorry if I forgot to mention someone)

TODO-RELEASE

+0 −2

Original line number	Original line	Diff line number	Diff line
	To be addressed in 7.19.6 (planned release: August 2009)		To be addressed in 7.19.6 (planned release: August 2009)
	=========================		=========================

	246 - small logic error with CURLOPT_NOPROXY

	248 - "Pausing pipeline problems."		248 - "Pausing pipeline problems."

	249 - Wildcard cert name checking and null termination		249 - Wildcard cert name checking and null termination

lib/url.c

+7 −4

Original line number	Original line	Diff line number	Diff line
	@@ -4419,14 +4419,17 @@ static CURLcode create_conn(struct SessionHandle *data,
	}		}
	}		}

	if(!proxy)
	proxy = detect_proxy(conn);		if(data->set.str[STRING_NOPROXY] &&
	else if(data->set.str[STRING_NOPROXY]) {		check_noproxy(conn->host.name, data->set.str[STRING_NOPROXY])) {
	if(check_noproxy(conn->host.name, data->set.str[STRING_NOPROXY])) {		if(proxy) {
	free(proxy); /* proxy is in exception list */		free(proxy); /* proxy is in exception list */
	proxy = NULL;		proxy = NULL;
	}		}
	}		}
			else if(!proxy)
			proxy = detect_proxy(conn);

	if(proxy && !*proxy) {		if(proxy && !*proxy) {
	free(proxy); /* Don't bother with an empty proxy string */		free(proxy); /* Don't bother with an empty proxy string */
	proxy = NULL;		proxy = NULL;