Commit 0ab97ba0 authored by Daniel Stenberg's avatar Daniel Stenberg
Browse files

chunked decoder: track overflows correctly 

The code didn't properly check the return codes to detect overflows so
it could trigger incorrectly. Like on mingw32.

Regression introduced in 345891ed (curl 7.35.0)

Bug: http://curl.haxx.se/mail/lib-2014-02/0097.html
Reported-by: LM
parent bff73989

lib/http_chunks.c

+2 −2
Original line number Diff line number Diff line
@@ -162,8 +162,8 @@ CHUNKcode Curl_httpchunk_read(struct connectdata *conn, 
        }



        ch->datasize=curlx_strtoofft(ch->hexbuffer, &endptr, 16);

        if(errno == ERANGE)

          /* over or underflow is an error */

        if((ch->datasize == CURL_OFF_T_MAX) && (errno == ERANGE))

          /* overflow is an error */

          return CHUNKE_ILLEGAL_HEX;

        ch->state = CHUNK_LF; /* now wait for the CRLF */

      }