Commit f68b1efc authored Jan 16, 2019 by William A. Rowe Jr

mod_negotiation: LanguagePriority tags must be treated case-insensitive,

per https://tools.ietf.org/html/rfc7231#section-3.1.3.1  

PR: 39730
Backports: r1850989
Submitted by: jailletc36
Reviewed by: jailletc36, wrowe, jim



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1851468 13f79535-47bb-0310-9956-ffa450edef68

parent d1f3cd33

CHANGES

+3 −0

Original line number	Diff line number	Diff line
		-- coding: utf-8 --
		Changes with Apache 2.4.38

		*) mod_negotiation: Treat LanguagePriority as case-insensitive to match
		AddLanguage behavior and HTTP specification. PR 39730 [Christophe Jaillet]

		*) mod_md: incorrect behaviour when synchronizing ongoing ACME challenges
		have been fixed. [Michael Kaufmann, Stefan Eissing]

STATUS

+0 −6

Original line number	Diff line number	Diff line
		@@ -213,12 +213,6 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
		2.4.x patch: svn merge -c 1851093 ^/httpd/httpd/trunk .
		+1: jailletc36 (by inspection), jim

		*) mod_negotiation: LanguagePriority tags must be treated case-insensitive,
		per https://tools.ietf.org/html/rfc7231#section-3.1.3.1 PR 39730
		trunk patch: http://svn.apache.org/r1850989
		2.4.x patch: svn merge -c 1850989 ^/httpd/httpd/trunk .
		+1: jailletc36, wrowe, jim

		*) easy proposals:
		- mod_authn_dbm: Return APR_SUCCESS which is equivalent but more readable
		than 'rv' here

modules/mappers/mod_negotiation.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1459,7 +1459,7 @@ static int find_lang_index(apr_array_header_t accept_langs, char lang)
		alang = (const char **) accept_langs->elts;

		for (i = 0; i < accept_langs->nelts; ++i) {
		if (!strncmp(lang, alang, strlen(alang))) {
		if (!ap_cstr_casecmpn(lang, alang, strlen(alang))) {
		return i;
		}
		alang += (accept_langs->elt_size / sizeof(char*));