Loading STATUS +9 −3 Changes for STATUS: 9 added lines, 3 removed lines. Original line number Diff line number Diff line APACHE 2.0 STATUS: -*-text-*- Last modified at [$Date: 2004/08/26 21:06:13 $] Last modified at [$Date: 2004/08/26 21:18:37 $] Release: Loading Loading @@ -163,7 +163,10 @@ PATCHES TO BACKPORT FROM 2.1 jerenkrantz asks: Isn't this what apr_table_merge is for? nd replies: yep. But cookies won't be merged, because browsers don't support it. +1: nd jerenkrantz: Couldn't we copy the table and merge the values somehow? This just seems like a lot of code to duplicate what we have already. *shrug* Regardless, patch looks okay... +1: nd, jerenkrantz *) Fix memory leak in mod_rewrite. PR 27862. (2.0 + 1.3) http://www.apache.org/~nd/mod_rewrite_fixleak.diff Loading @@ -186,7 +189,10 @@ PATCHES TO BACKPORT FROM 2.1 completely forgotten where. nd: we stop recursions in the core now (for subrequests and internal redirects). Therefore the check here is no longer necessary. +1: nd jerenkrantz: Aha. ap_is_recursion_limit_exceeded() is the function I was thinking of, but couldn't find. (I was searching for 'recursive' not 'recursion'.) +1: nd, jerenkrantz *) mod_dav: Send an EOS at the end of the multistatus brigade. http://cvs.apache.org/viewcvs.cgi/httpd-2.0/modules/dav/main/mod_dav.c?r1=1.105&r2=1.106 Loading Loading
STATUS +9 −3 Changes for STATUS: 9 added lines, 3 removed lines. Original line number Diff line number Diff line APACHE 2.0 STATUS: -*-text-*- Last modified at [$Date: 2004/08/26 21:06:13 $] Last modified at [$Date: 2004/08/26 21:18:37 $] Release: Loading Loading @@ -163,7 +163,10 @@ PATCHES TO BACKPORT FROM 2.1 jerenkrantz asks: Isn't this what apr_table_merge is for? nd replies: yep. But cookies won't be merged, because browsers don't support it. +1: nd jerenkrantz: Couldn't we copy the table and merge the values somehow? This just seems like a lot of code to duplicate what we have already. *shrug* Regardless, patch looks okay... +1: nd, jerenkrantz *) Fix memory leak in mod_rewrite. PR 27862. (2.0 + 1.3) http://www.apache.org/~nd/mod_rewrite_fixleak.diff Loading @@ -186,7 +189,10 @@ PATCHES TO BACKPORT FROM 2.1 completely forgotten where. nd: we stop recursions in the core now (for subrequests and internal redirects). Therefore the check here is no longer necessary. +1: nd jerenkrantz: Aha. ap_is_recursion_limit_exceeded() is the function I was thinking of, but couldn't find. (I was searching for 'recursive' not 'recursion'.) +1: nd, jerenkrantz *) mod_dav: Send an EOS at the end of the multistatus brigade. http://cvs.apache.org/viewcvs.cgi/httpd-2.0/modules/dav/main/mod_dav.c?r1=1.105&r2=1.106 Loading