Commit dddd48f7 authored by Guenter Knauf's avatar Guenter Knauf
Browse files

Modified rotatelogs to behave the same as the core log writer. 

Author wrowe, reviewed by rjung, sf.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.0.x@1004971 13f79535-47bb-0310-9956-ffa450edef68
parent bfe71bff

STATUS

+0 −16
Changes for STATUS: 0 added lines, 16 removed lines.
Original line number Diff line number Diff line
@@ -132,22 +132,6 @@ RELEASE SHOWSTOPPERS: 
PATCHES ACCEPTED TO BACKPORT FROM TRUNK:

  [ start all new proposals below, under PATCHES PROPOSED. ]



  * Stupid-simple patch specific to give rotatelogs the same behavior

    as the core log writer;

    +1: wrowe, rjung, sf

--- support/rotatelogs.c	(revision 733150)

+++ support/rotatelogs.c	(working copy)

@@ -208,7 +208,8 @@

                 sprintf(buf2, "%s.%010d", szLogRoot, tLogStart);

             }

             tLogEnd = tLogStart + tRotation;

-            apr_file_open(&nLogFD, buf2, APR_READ | APR_WRITE | APR_CREATE | APR_APPEND,

+            apr_file_open(&nLogFD, buf2, 

+                          APR_APPEND | APR_WRITE | APR_CREATE | APR_LARGEFILE,

                           APR_OS_DEFAULT, pool);

             if (nLogFD == NULL) {

                 /* Uh-oh. Failed to open the new log file. Try to clear



  * mod_negotiation: PR 33112 - Fix for query string preservation after content negotiation

    Trunk patch: http://svn.apache.org/viewvc?view=revision&revision=915407

    2.2.x patch: http://svn.apache.org/viewvc?view=revision&revision=917017

support/rotatelogs.c

+2 −1
Changes for support/rotatelogs.c: 2 added lines, 1 removed line.
Original line number Diff line number Diff line
@@ -208,7 +208,8 @@ int main (int argc, const char * const argv[]) 
                sprintf(buf2, "%s.%010d", szLogRoot, tLogStart);

            }

            tLogEnd = tLogStart + tRotation;

            apr_file_open(&nLogFD, buf2, APR_READ | APR_WRITE | APR_CREATE | APR_APPEND,

            apr_file_open(&nLogFD, buf2, 

                          APR_APPEND | APR_WRITE | APR_CREATE | APR_LARGEFILE,

                          APR_OS_DEFAULT, pool);

            if (nLogFD == NULL) {

                /* Uh-oh. Failed to open the new log file. Try to clear