Commit d484f620 authored by Eric Covener's avatar Eric Covener
Browse files

always use (via break) the LDAP connection we're looking at once it's a match, 

whether it's used as-is or has just been unbound.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1086433 13f79535-47bb-0310-9956-ffa450edef68
parent 389692d3

modules/ldap/util_ldap.c

+1 −4
Changes for modules/ldap/util_ldap.c: 1 added line, 4 removed lines.
Original line number Diff line number Diff line
@@ -674,14 +674,11 @@ static util_ldap_connection_t * 
                                  "Removing LDAP connection last used %" APR_TIME_T_FMT " seconds ago", 

                                  (now - l->freed) / APR_USEC_PER_SEC);

                    uldap_connection_unbind(l);

                    /* Go ahead and use it, so we don't create more just to unbind some other old ones */

                    break; 

                    /* Go ahead (by falling through) and use it, so we don't create more just to unbind some other old ones */

                }

            }

            else { 

            break;

        }

        }

#if APR_HAS_THREADS

            /* If this connection didn't match the criteria, then we

             * need to unlock the mutex so it is available to be reused.