Commit d3e0ad6e authored by Eric Covener's avatar Eric Covener
Browse files

avoid SO_REUSEPORT w/o ListenCoresBucketsRatio 

Can lead to unintended/confusing sharing between 
multiple servers started by the same ID.



git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1777923 13f79535-47bb-0310-9956-ffa450edef68
parent 57478590

CHANGES

+3 −0
Original line number Diff line number Diff line 
                                                         -*- coding: utf-8 -*-

Changes with Apache 2.5.0



  *) Don't set SO_REUSEPORT unless ListenCoresBucketsRatio is greater

     than zero.  [Eric Covener]



  *) mod_http2: streaming of request output now reacts timely to data

     from other streams becoming available. Same for new incoming requests.

     [Stefan Eissing]

server/listen.c

+1 −1
Original line number Diff line number Diff line
@@ -146,7 +146,7 @@ static apr_status_t make_sock(apr_pool_t *p, ap_listen_rec *server, int do_bind_ 
#endif



#if defined(SO_REUSEPORT)

    if (ap_have_so_reuseport) {

    if (ap_have_so_reuseport && ap_listencbratio > 0) {

        int thesock;

        apr_os_sock_get(&thesock, s);

        if (setsockopt(thesock, SOL_SOCKET, SO_REUSEPORT,