Loading STATUS +4 −1 Changes for STATUS: 4 added lines, 1 removed line. Original line number Diff line number Diff line Loading @@ -262,7 +262,7 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK: http://svn.apache.org/viewvc?view=rev&revision=484783 2.2.x version of patch: Trunk version works. +1: jim +1: jim, rpluem * mod_proxy_balancer: Remove unnecessary lock/unlock for the post_request hook. We are actually doing nothing here. Loading @@ -273,6 +273,8 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK: 2.2.x version of patch: Trunk version works. +1: jim +0: rpluem: Shouldn't we remove this code on 2.2.x? Keeping seems to be ok for me on trunk, but on a stable branch? * mod_proxy: Log unlock errors (as we do with locking errors). Add additional clarification on where the error occurred. Loading @@ -283,4 +285,5 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK: 2.2.x version of patch: Trunk version works. +1: jim rpluem says: r484787 does not apply cleanly to 2.2.x Loading
STATUS +4 −1 Changes for STATUS: 4 added lines, 1 removed line. Original line number Diff line number Diff line Loading @@ -262,7 +262,7 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK: http://svn.apache.org/viewvc?view=rev&revision=484783 2.2.x version of patch: Trunk version works. +1: jim +1: jim, rpluem * mod_proxy_balancer: Remove unnecessary lock/unlock for the post_request hook. We are actually doing nothing here. Loading @@ -273,6 +273,8 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK: 2.2.x version of patch: Trunk version works. +1: jim +0: rpluem: Shouldn't we remove this code on 2.2.x? Keeping seems to be ok for me on trunk, but on a stable branch? * mod_proxy: Log unlock errors (as we do with locking errors). Add additional clarification on where the error occurred. Loading @@ -283,4 +285,5 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK: 2.2.x version of patch: Trunk version works. +1: jim rpluem says: r484787 does not apply cleanly to 2.2.x