Commit 9ecdd28a authored by Yann Ylavic's avatar Yann Ylavic
Browse files

Switch mod_log_config %M proposal to the %{foo}T update. 

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.2.x@1681022 13f79535-47bb-0310-9956-ffa450edef68
parent 4f1e241a

STATUS

+3 −25
Original line number Diff line number Diff line
@@ -124,12 +124,9 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK: 


   * mod_log_config: Add new format flag for requestion duration in milliseconds

     trunk patch: http://svn.apache.org/r1675533

     2.2.x patch: https://people.apache.org/~ylavic/httpd-2.2.x-req_duration_milliseconds-v1.patch

     2.2.x patch: http://people.apache.org/~ylavic/httpd-2.2.x-mod_log_config-time_taken_fmt.patch

                  (modulo CHANGES)

     +1: ylavic, breser

     ylavic: first accepted merge reverted in r1679205, due to missing get_request_end_time() in 2.2.x.

             v1 now s/get_request_end_time(r)/apr_time_now()/

             druggeri vote discarded.

     +1: ylavic

     rjung: I know this was already committed to 2.4 although not yet released,

            but: wouldn't it be better to overload the existing %D with %{ms}D

            to save the precious "M". We slowly run out of chars for access log
@@ -140,7 +137,7 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK: 
     ylavic: +1 too, but maybe use %{fmt}T instead?  We already either "loose" %T or %D

             since %{s} = %T and %{us} = %D, T for Time (taken) is maybe more meaningful?

     rjung: It seems most prefer the %{...}T variant. I'll switch to that.

     ylavic: OK, not a strong opinion either... Added a comment below too :)

     ylavic: OK, I merged the below proposal with this one. breser vote discared.



   * mpm_winnt service.c: Accept utf-8 service names/descriptions for i18n.

     trunk patches: http://svn.apache.org/r1611165
@@ -148,25 +145,6 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK: 
     2.2.x patch: http://people.apache.org/~wrowe/httpd-2.2-utf8-servicename.patch

     +1: wrowe, gsmith



  *) mod_log_config: instead of using the dedicated pattern format "%M" for

     duration milliseconds, overload the existing "%D" to choose the time

     precision ("%{s}D" for seconds, "%{ms}D" for milliseconds and

     "%{us}D" for microseconds). The existing %T and %D without precision

     are kept for compatibility. The previously introduced "%M" is removed,

     it has not yet been released.

     Format pattern characters are rare, so we should only use a new one

     if an existing one isn't a good fit.

     trunk patch: http://svn.apache.org/r1680895

                  http://svn.apache.org/r1680900

     2.4.x patch: http://people.apache.org/~rjung/patches/httpd-2.4.x-mod_log_config-duration_units.patch

                  (trunk works plus CHANGES)

     2.2.x patch: http://people.apache.org/~rjung/patches/httpd-2.2.x-mod_log_config-duration_units.patch

     +1: rjung

     ylavic: Can't we backport the whole r979120+r1467765 while at it?

     rjung: Sure that would be useful. In light of logjam I would hope to not defer the

            next release to much, so we should IMHO propose that bigger change independently

            and on top of this small and easy to review one.





PATCHES/ISSUES THAT ARE STALLED