Commit 99696d53 authored by Ben Laurie's avatar Ben Laurie
Browse files

Add PKCS#7 support. 


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@424707 13f79535-47bb-0310-9956-ffa450edef68
parent 5c2548b0

modules/ssl/mod_ssl.c

+3 −0
Original line number Diff line number Diff line
@@ -111,6 +111,9 @@ static const command_rec ssl_config_cmds[] = { 
    SSL_CMD_SRV(CertificateChainFile, TAKE1,

                "SSL Server CA Certificate Chain file "

                "(`/path/to/file' - PEM encoded)")

    SSL_CMD_SRV(PKCS7CertificateFile, TAKE1,

		"PKCS#7 file containing server certificate and chain"

		" certificates (`/path/to/file' - PEM ecnoded)")

    SSL_CMD_ALL(CACertificatePath, TAKE1,

                "SSL CA Certificate path "

                "(`/path/to/dir' - contains PEM encoded files)")

modules/ssl/ssl_engine_config.c

+16 −0
Original line number Diff line number Diff line
@@ -779,6 +779,22 @@ const char *ssl_cmd_SSLCertificateChainFile(cmd_parms *cmd, 
    return NULL;

}



const char *ssl_cmd_SSLPKCS7CertificateFile(cmd_parms *cmd,

                                            void *dcfg,

                                            const char *arg)

{

    SSLSrvConfigRec *sc = mySrvConfig(cmd->server);

    const char *err;



    if ((err = ssl_cmd_check_file(cmd, &arg))) {

        return err;

    }



    sc->server->pkcs7 = arg;



    return NULL;

}



#define NO_PER_DIR_SSL_CA \

    "Your ssl library does not have support for per-directory CA"

modules/ssl/ssl_engine_init.c

+16 −1
Original line number Diff line number Diff line
@@ -357,7 +357,7 @@ static void ssl_init_server_check(server_rec *s, 
     * check for important parameters and the

     * possibility that the user forgot to set them.

     */

    if (!mctx->pks->cert_files[0]) {

    if (!mctx->pks->cert_files[0] && !mctx->pkcs7) {

        ap_log_error(APLOG_MARK, APLOG_ERR, 0, s,

                "No SSL Certificate set [hint: SSLCertificateFile]");

        ssl_die();
@@ -648,6 +648,16 @@ static void ssl_init_ctx_crl(server_rec *s, 
    }

}



static void ssl_init_ctx_pkcs7_cert_chain(server_rec *s,modssl_ctx_t *mctx)

{

    STACK_OF(X509) *certs=ssl_read_pkcs7(s, mctx->pkcs7);

    int n;



    if (!mctx->ssl_ctx->extra_certs)

	for (n = 1; n < sk_X509_num(certs); ++n)

	    SSL_CTX_add_extra_chain_cert(mctx->ssl_ctx, sk_X509_value(certs, n));

}



static void ssl_init_ctx_cert_chain(server_rec *s,

                                    apr_pool_t *p,

                                    apr_pool_t *ptemp,
@@ -657,6 +667,11 @@ static void ssl_init_ctx_cert_chain(server_rec *s, 
    int i, n;

    const char *chain = mctx->cert_chain;



    if (mctx->pkcs7) {

	ssl_init_ctx_pkcs7_cert_chain(s,mctx);

	return;

    }



    /*

     * Optionally configure extra server certificate chain certificates.

     * This is usually done by OpenSSL automatically when one of the

modules/ssl/ssl_engine_pphrase.c

+26 −17
Original line number Diff line number Diff line
@@ -185,16 +185,25 @@ void ssl_pphrase_Handle(server_rec *s, apr_pool_t *p) 
         * Read in server certificate(s): This is the easy part

         * because this file isn't encrypted in any way.

         */

        if (sc->server->pks->cert_files[0] == NULL) {

        if (sc->server->pks->cert_files[0] == NULL

	    && sc->server->pkcs7 == NULL) {

            ap_log_error(APLOG_MARK, APLOG_ERR, 0, pServ,

                         "Server should be SSL-aware but has no certificate "

                         "configured [Hint: SSLCertificateFile]");

            ssl_die();

        }



        algoCert = SSL_ALGO_UNKNOWN;

        algoKey  = SSL_ALGO_UNKNOWN;

        for (i = 0, j = 0; i < SSL_AIDX_MAX && sc->server->pks->cert_files[i] != NULL; i++) {



        for (i = 0, j = 0; i < SSL_AIDX_MAX

		 && (sc->server->pks->cert_files[i] != NULL

		     || sc->server->pkcs7); i++) {

	    if (sc->server->pkcs7) {

		STACK_OF(X509) *certs = ssl_read_pkcs7(pServ, sc->server->pkcs7);



		pX509Cert = sk_X509_value(certs, 0);

		i = SSL_AIDX_MAX;

	    } else {

		apr_cpystrn(szPath, sc->server->pks->cert_files[i], sizeof(szPath));

		if ((rv = exists_and_readable(szPath, p, NULL)) != APR_SUCCESS) {

		    ap_log_error(APLOG_MARK, APLOG_ERR, rv, s,
@@ -208,7 +217,7 @@ void ssl_pphrase_Handle(server_rec *s, apr_pool_t *p) 
		    ssl_log_ssl_error(APLOG_MARK, APLOG_ERR, s);

		    ssl_die();

		}



	    }

            /*

             * check algorithm type of certificate and make

             * sure only one certificate per type is used.

modules/ssl/ssl_private.h

+5 −0
Original line number Diff line number Diff line
@@ -442,6 +442,7 @@ typedef struct { 
    const char   *pphrase_dialog_path;



    const char  *cert_chain;

    const char  *pkcs7;



    /** certificate revocation list */

    const char  *crl_path;
@@ -510,6 +511,7 @@ const char *ssl_cmd_SSLCipherSuite(cmd_parms *, void *, const char *); 
const char  *ssl_cmd_SSLCertificateFile(cmd_parms *, void *, const char *);

const char  *ssl_cmd_SSLCertificateKeyFile(cmd_parms *, void *, const char *);

const char  *ssl_cmd_SSLCertificateChainFile(cmd_parms *, void *, const char *);

const char  *ssl_cmd_SSLPKCS7CertificateFile(cmd_parms *, void *, const char *);

const char  *ssl_cmd_SSLCACertificatePath(cmd_parms *, void *, const char *);

const char  *ssl_cmd_SSLCACertificateFile(cmd_parms *, void *, const char *);

const char  *ssl_cmd_SSLCADNRequestPath(cmd_parms *, void *, const char *);
@@ -651,6 +653,9 @@ const char *ssl_asn1_keystr(int keytype); 
const char *ssl_asn1_table_keyfmt(apr_pool_t *p,

                                  const char *id,

                                  int keytype);



STACK_OF(X509) *ssl_read_pkcs7(server_rec *s, const char *pkcs7);



/**  Mutex Support  */

int          ssl_mutex_init(server_rec *, apr_pool_t *);

int          ssl_mutex_reinit(server_rec *, apr_pool_t *);