Loading STATUS +10 −0 Changes for STATUS: 10 added lines, 0 removed lines. Original line number Diff line number Diff line Loading @@ -171,6 +171,16 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK: http://svn.apache.org/r1643543 2.4.x patch: trunk works (module CHANGES) +1: ylavic, jim trawick: Eric and I were working through this and I (at least) ran into this particular roadblock: output_failed sometimes means that we couldn't write to the client and sometimes means that we couldn't read from the client; laster, output_fails triggers setting the status to 400. HTTP status shouldn't be 400 for a problem writing to the client. (Maybe I missed some guarantee that 400 is only for an error reading enough request body??) I think it would be good to separate output_failed from input_failed so that the code is more clear and we can more easily tell that the status code is appropriate. (And unfortunately I don't volunteer to test it :( ) * core: Add ap_errorlog_provider to make ErrorLog logging modular. This backport keeps syslog logging as part of httpd core and only adds Loading Loading
STATUS +10 −0 Changes for STATUS: 10 added lines, 0 removed lines. Original line number Diff line number Diff line Loading @@ -171,6 +171,16 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK: http://svn.apache.org/r1643543 2.4.x patch: trunk works (module CHANGES) +1: ylavic, jim trawick: Eric and I were working through this and I (at least) ran into this particular roadblock: output_failed sometimes means that we couldn't write to the client and sometimes means that we couldn't read from the client; laster, output_fails triggers setting the status to 400. HTTP status shouldn't be 400 for a problem writing to the client. (Maybe I missed some guarantee that 400 is only for an error reading enough request body??) I think it would be good to separate output_failed from input_failed so that the code is more clear and we can more easily tell that the status code is appropriate. (And unfortunately I don't volunteer to test it :( ) * core: Add ap_errorlog_provider to make ErrorLog logging modular. This backport keeps syslog logging as part of httpd core and only adds Loading