Commit 3afa6d14 authored by Yann Ylavic's avatar Yann Ylavic
Browse files

SO_REUSEPORT with (part of) wrowe's concerns. 

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1679718 13f79535-47bb-0310-9956-ffa450edef68
parent ea07c73f

STATUS

+9 −2
Changes for STATUS: 9 added lines, 2 removed lines.
Original line number Diff line number Diff line
@@ -205,10 +205,17 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK: 
                  http://svn.apache.org/r1640763

                  http://svn.apache.org/r1643179

                  http://svn.apache.org/r1656368

     2.4.x patch: http://people.apache.org/~jim/patches/httpd-2.4.x-ap_listeners_buckets-v2.patch

     +1: ylavic, jim

                  http://svn.apache.org/r1679714

     2.4.x patch: http://people.apache.org/~ylavic/httpd-2.4.x-ap_listeners_buckets-v3.patch

     +1: ylavic

     wrowe: the statics are not explicitly initialized for clarity

            ap_log_common is horribly named, perhaps ap_log_mpm_common()?

     ylavic: v3 with s/ap_log_common/ap_log_mpm_common/ (jim's vote discarded).

             globals (including statics) not initialized are implicitely initialized to zero

             per C standard, and go to .bss (zeroed as a whole at load time), whereas the ones

             explicitly initialized (even to 0 depending on the compiler/flags) go to .data and

             have each to be set to their init value (which may take some cycles at load time).

             I personaly don't see explicit initializations to {0} as a win (even for clarity...).



  *) http: Make ap_die() robust against any HTTP error code and not modify

     response status (finally logged) when nothing is to be done. PR 56035.