Commit 3767a822 authored by Justin Erenkrantz's avatar Justin Erenkrantz
Browse files

Clarify note on ap_discard_request_body(). If we want to change it,

we should do it before .37 - hence its remaining as a showstopper.

Add note on the 304 showstopper (aka PR 9673 in BZ).


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95555 13f79535-47bb-0310-9956-ffa450edef68
parent 35f7b146
Loading
Loading
Loading
Loading
+17 −9
Original line number Diff line number Diff line
APACHE 2.0 STATUS:                                              -*-text-*-
Last modified at [$Date: 2002/06/06 01:08:06 $]
Last modified at [$Date: 2002/06/07 00:59:03 $]

Release:

@@ -67,21 +67,29 @@ RELEASE SHOWSTOPPERS:
      BrianP says:  how about "ap_apachectl()"?
      Justin says to BrianP: "Eww."

    * Chunked trailer support is broken.
    * Potentially remove ap_discard_request_body()
      Message-ID: <20020531142047.W19485@apache.org>
      Status: rbb committed a fix to http_protocol.c, but we still need to
              figure out what to do with ap_discard_request_body.  Should
              we still rearrange it like the patches below have it?  Or,
              can we remove all callers of ap_discard_request_body and
              only do it in ap_finalize_request_protocol?  (rbb hinted that
              we can't do it in ap_finalize_request_protocol because of
              potential 413 errors which would be detected too late.)
                  <3CFFFA12.1040007@cnet.com>
      Status: Can we remove all callers of ap_discard_request_body and
              only do it in ap_finalize_request_protocol?  If we do it
              in finalize_request_protocol, we may not catch 413 errors
              until after the request is served.  Oops.  But, if we
              didn't NEED the body in the first place, then it isn't
              really a 413, is it?
      Patches (may or may not be applicable):
                For the core and various modules:
                  <20020602164041.N19485@apache.org>
                For mod_dav:
                  <20020602161511.K19485@apache.org>
                  <20020602162838.L19485@apache.org>

    * Returning invalid 304 errors when filters are present.  [PR 9673]
      Message-ID: <Pine.GSO.4.44.0206061713320.3848-100000@lab26.lacfas.hec.ca>
      Status: We should set r->no_local_copy, but where can we set it?
              We must set it before the handlers are run so that the
              appropriate handler can call ap_meets_conditions() before
              generating the data.

CURRENT VOTES:

    * apachectl should revert to just being an init script and