Commit 159e64c3 authored by Cliff Woolley's avatar Cliff Woolley
Browse files

Fix the rest of the apr_pool_userdata_setn() bogosity w.r.t. DSO modules. 

It's totally unsafe to use apr_pool_userdata_setn() in the post_config
phase of a module, since on some platforms when the DSO gets reloaded
between phases, the data segment will be at a different address on the
second phase and the userdata_get() call will fail.

PR: 9413
Submitted by: Tsuyoshi Sasamoto <nazonazo@super.win.ne.jp>


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@95287 13f79535-47bb-0310-9956-ffa450edef68
parent 28c0abb2

ssl_scache.c

+1 −1
Changes for ssl_scache.c: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -94,7 +94,7 @@ void ssl_scache_init(server_rec *s, apr_pool_t *p) 


        apr_pool_userdata_get(&data, userdata_key, s->process->pool);

        if (!data) {

            apr_pool_userdata_setn((const void *)1, userdata_key,

            apr_pool_userdata_set((const void *)1, userdata_key,

                                  apr_pool_cleanup_null, s->process->pool);

            return;

        }