Commit 0d594565 authored by Brian Pane's avatar Brian Pane
Browse files

use struct assignment instead of memcpy so the compiler can decide whether to... 

use struct assignment instead of memcpy so the compiler can decide whether to inline the copy loop or call memcpy

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@208972 13f79535-47bb-0310-9956-ffa450edef68
parent 4bc2c46c

modules/loggers/mod_log_config.c

+2 −3
Changes for modules/loggers/mod_log_config.c: 2 added lines, 3 removed lines.
Original line number Diff line number Diff line
@@ -579,7 +579,7 @@ static const char *log_request_time(request_rec *r, char *a) 
#endif

        unsigned t_seconds = (unsigned)apr_time_sec(request_time);

        unsigned i = t_seconds & TIME_CACHE_MASK;

        memcpy(cached_time, &(request_time_cache[i]), sizeof(*cached_time));

        *cached_time = request_time_cache[i];

        if ((t_seconds != cached_time->t) ||

            (t_seconds != cached_time->t_validate)) {
@@ -605,8 +605,7 @@ static const char *log_request_time(request_rec *r, char *a) 
                         xt.tm_year+1900, xt.tm_hour, xt.tm_min, xt.tm_sec,

                         sign, timz / (60*60), (timz % (60*60)) / 60);

            cached_time->t_validate = t_seconds;

            memcpy(&(request_time_cache[i]), cached_time,

                   sizeof(*cached_time));

            request_time_cache[i] = *cached_time;

        }

        return cached_time->timestr;

    }