Commit 0a22c4bf authored by Doug MacEachern's avatar Doug MacEachern
Browse files

move srand() call from ssl_rand_choosenum() to ssl_init_Child() 

this was being called twice per-connection with 'SSLRandom connect builtin'
configured (which is in the default config)

this also gets rid of two time() syscalls per-connection

PR:
Obtained from:
Submitted by:
Reviewed by:


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl@92232 13f79535-47bb-0310-9956-ffa450edef68
parent 3a2fa0ff

ssl_engine_init.c

+3 −0
Changes for ssl_engine_init.c: 3 added lines, 0 removed lines.
Original line number Diff line number Diff line
@@ -967,6 +967,9 @@ void ssl_init_Child(apr_pool_t *p, server_rec *s) 
    SSLModConfigRec *mc = myModConfig(s);

    mc->pid = getpid(); /* only call getpid() once per-process */



    /* XXX: there should be an ap_srand() function */

    srand((unsigned int)time(NULL));



     /* open the mutex lockfile */

     ssl_mutex_reinit(s, p);

     return;

ssl_engine_rand.c

+0 −1
Changes for ssl_engine_rand.c: 0 added lines, 1 removed line.
Original line number Diff line number Diff line
@@ -203,7 +203,6 @@ static int ssl_rand_choosenum(int l, int h) 
    int i;

    char buf[50];



    srand((unsigned int)time(NULL));

    apr_snprintf(buf, sizeof(buf), "%.0f",

                 (((double)(rand()%RAND_MAX)/RAND_MAX)*(h-l)));

    i = atoi(buf)+1;