Commit 069614db authored by Jeff Trawick's avatar Jeff Trawick
Browse files

attempt to fix some issues in mod_cache found by gcc 

(use of rv and date before setting them)


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@90953 13f79535-47bb-0310-9956-ffa450edef68
parent 2ffed66b

modules/experimental/mod_cache.c

+6 −1
Original line number Diff line number Diff line
@@ -540,6 +540,11 @@ int ap_cache_in_filter(ap_filter_t *f, apr_bucket_brigade *in) 
        /* update headers */



        /* remove this filter ??? */



        /* XXX is this right?  we must set rv to something other than OK 

         * in this path

         */

        rv = HTTP_NOT_MODIFIED;

    }

    /* pre-existing cache handle and new entity, replace entity with this one */

    else {
@@ -584,8 +589,8 @@ int ap_cache_in_filter(ap_filter_t *f, apr_bucket_brigade *in) 
        ap_table_set(r->headers_out, "Date", dates);

        ap_log_error(APLOG_MARK, APLOG_DEBUG | APLOG_NOERRNO, 0, r->server,

                     "cache: Added date header");

    }

        info->date = date;

    }



    /* set response_time for HTTP/1.1 age calculations */

    info->response_time = now;