Commit 04e72589 authored by Greg Ames's avatar Greg Ames
Browse files

Fix the naming of the apr_threadattr_detach_xxx functions. get and set were 

reversed.

This may have broken the Unix threaded mpm's when they started using the
bogus "set" function.  A likely symptom would be failure to stop a threaded
process cleanly.

Note: it appears these functions are essentially no-ops except in Unix.


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@88805 13f79535-47bb-0310-9956-ffa450edef68
parent afc30dfd

server/mpm/experimental/perchild/perchild.c

+1 −1
Original line number Diff line number Diff line
@@ -917,7 +917,7 @@ static void child_main(int child_num_arg) 
                    NULL, pchild);



    apr_threadattr_create(&worker_thread_attr, pchild);

    apr_threadattr_detach_set(worker_thread_attr);                                     

    apr_threadattr_detach_set(worker_thread_attr, 1);                                     

    apr_create_signal_thread(&thread, worker_thread_attr, check_signal, pchild);



    /* We are creating worker threads right now */

server/mpm/perchild/perchild.c

+1 −1
Original line number Diff line number Diff line
@@ -917,7 +917,7 @@ static void child_main(int child_num_arg) 
                    NULL, pchild);



    apr_threadattr_create(&worker_thread_attr, pchild);

    apr_threadattr_detach_set(worker_thread_attr);                                     

    apr_threadattr_detach_set(worker_thread_attr, 1);                                     

    apr_create_signal_thread(&thread, worker_thread_attr, check_signal, pchild);



    /* We are creating worker threads right now */

server/mpm/threaded/threaded.c

+1 −1
Original line number Diff line number Diff line
@@ -657,7 +657,7 @@ static void child_main(int child_num_arg) 
    apr_lock_create(&pipe_of_death_mutex, APR_MUTEX, APR_INTRAPROCESS, 

                    NULL, pchild);

    apr_threadattr_create(&thread_attr, pchild);

    apr_threadattr_detach_set(thread_attr);

    apr_threadattr_detach_set(thread_attr, 1);



    rv = apr_create_signal_thread(&thread, thread_attr, check_signal, pchild);

    if (rv != APR_SUCCESS) {