Commit e80f3b6a authored by Kurt Roeckx's avatar Kurt Roeckx
Browse files

Cast to an unsigned type before negating 



llvm's ubsan reported:
runtime error: negation of -9223372036854775808 cannot be represented in
type 'int64_t' (aka 'long'); cast to an unsigned type to negate this
value to itself

Found using libfuzzer

Reviewed-by: default avatarRich Salz <rsalz@openssl.org>

GH: #1908
parent 866e505e

crypto/asn1/a_int.c

+1 −1
Original line number Diff line number Diff line
@@ -289,7 +289,7 @@ static int asn1_get_int64(int64_t *pr, const unsigned char *b, size_t blen, 
            ASN1err(ASN1_F_ASN1_GET_INT64, ASN1_R_TOO_SMALL);

            return 0;

        }

        *pr = -(int64_t)r;

        *pr = -(uint64_t)r;

    } else {

        if (r > INT64_MAX) {

            ASN1err(ASN1_F_ASN1_GET_INT64, ASN1_R_TOO_LARGE);