Commit e14f14d3 authored by mancha's avatar mancha Committed by Ben Laurie
Browse files

Fix eckey_priv_encode() 

Fix eckey_priv_encode to return an error on failure of i2d_ECPrivateKey.
parent 79c6c4e8

CHANGES

+4 −0
Original line number Diff line number Diff line
@@ -4,6 +4,10 @@ 


 Changes between 1.0.2 and 1.1.0  [xx XXX xxxx]



  *) Fix eckey_priv_encode so it immediately returns an error upon a failure

     in i2d_ECPrivateKey.

     [mancha <mancha1@zoho.com>]



  *) Fix some double frees. These are not thought to be exploitable.

     [mancha <mancha1@zoho.com>]

crypto/ec/ec_ameth.c

+1 −0
Original line number Diff line number Diff line
@@ -356,6 +356,7 @@ static int eckey_priv_encode(PKCS8_PRIV_KEY_INFO *p8, const EVP_PKEY *pkey) 
		EC_KEY_set_enc_flags(ec_key, old_flags);

		OPENSSL_free(ep);

		ECerr(EC_F_ECKEY_PRIV_ENCODE, ERR_R_EC_LIB);

		return 0;

	}

	/* restore old encoding flags */

	EC_KEY_set_enc_flags(ec_key, old_flags);