Commit d6e92c0b authored by Pascal Cuoq's avatar Pascal Cuoq Committed by Kurt Roeckx
Browse files

Properly check return type of DH_compute_key() 



It returns -1 on error, not 0.

Signed-off-by: default avatarKurt Roeckx <kurt@roeckx.be>
Reviewed-by: default avatarRich Salz <rsalz@openssl.org>
MR #1231
parent f92768e6

test/dhtest.c

+2 −2
Original line number Diff line number Diff line
@@ -515,9 +515,9 @@ static int run_rfc5114_tests(void) 
         * Work out shared secrets using both sides and compare with expected

         * values.

         */

        if (!DH_compute_key(Z1, dhB->pub_key, dhA))

        if (DH_compute_key(Z1, dhB->pub_key, dhA) == -1)

            goto bad_err;

        if (!DH_compute_key(Z2, dhA->pub_key, dhB))

        if (DH_compute_key(Z2, dhA->pub_key, dhB) == -1)

            goto bad_err;



        if (memcmp(Z1, td->Z, td->Z_len))