Commit cb853a65 authored by Matt Caswell's avatar Matt Caswell
Browse files

Fix a mem leak in the ocsp app 



Free memory allocated in the parent process that is not needed in the
child. We also free it in the parent. Technically this isn't really
required since we end up calling exit() soon afterwards - but to
prevent false positives we free it anyway.

Fixes a Coverity issue.

Reviewed-by: default avatarTim Hudson <tjh@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/7335)

(cherry picked from commit c20a76f695922f409c316399f7290530f7728f19)
parent a2516f0c

apps/ocsp.c

+2 −0
Original line number Diff line number Diff line
@@ -950,6 +950,7 @@ static void spawn_loop(void) 
            sleep(30);

            break;

        case 0:             /* child */

            OPENSSL_free(kidpids);

            signal(SIGINT, SIG_DFL);

            signal(SIGTERM, SIG_DFL);

            if (termsig)
@@ -976,6 +977,7 @@ static void spawn_loop(void) 
    }



    /* The loop above can only break on termsig */

    OPENSSL_free(kidpids);

    syslog(LOG_INFO, "terminating on signal: %d", termsig);

    killall(0, kidpids);

}