Commit cb1c3d1a authored by Matt Caswell's avatar Matt Caswell
Browse files

Make sure we check the return value of extract_min_max() 



Commit 42d7d7dd turned this function from returning void to
returning an int error code. This instance of calling it was
missed.

Found by Coverity.

Reviewed-by: default avatarRich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/5338)
parent 62542d04

crypto/x509v3/v3_asid.c

+3 −1
Original line number Diff line number Diff line
@@ -667,7 +667,9 @@ static int asid_contains(ASIdOrRanges *parent, ASIdOrRanges *child) 
        for (;; p++) {

            if (p >= sk_ASIdOrRange_num(parent))

                return 0;

            extract_min_max(sk_ASIdOrRange_value(parent, p), &p_min, &p_max);

            if (!extract_min_max(sk_ASIdOrRange_value(parent, p), &p_min,

                                 &p_max))

                return 0;

            if (ASN1_INTEGER_cmp(p_max, c_max) < 0)

                continue;

            if (ASN1_INTEGER_cmp(p_min, c_min) > 0)