Commit 9f944291 authored by Samuel Weiser's avatar Samuel Weiser Committed by Matt Caswell
Browse files

BN_copy now propagates BN_FLG_CONSTTIME 



Reviewed-by: default avatarPaul Dale <paul.dale@oracle.com>
Reviewed-by: default avatarMatt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/4377)
parent 3de81a59

crypto/bn/bn_lib.c

+3 −0
Original line number Diff line number Diff line
@@ -332,6 +332,9 @@ BIGNUM *BN_copy(BIGNUM *a, const BIGNUM *b) 
    if (b->top > 0)

        memcpy(a->d, b->d, sizeof(b->d[0]) * b->top);



    if (BN_get_flags(b, BN_FLG_CONSTTIME) != 0)

        BN_set_flags(a, BN_FLG_CONSTTIME);



    a->top = b->top;

    a->neg = b->neg;

    bn_check_top(a);

crypto/bn/bn_mont.c

+0 −2
Original line number Diff line number Diff line
@@ -258,8 +258,6 @@ int BN_MONT_CTX_set(BN_MONT_CTX *mont, const BIGNUM *mod, BN_CTX *ctx) 
    R = &(mont->RR);            /* grab RR as a temp */

    if (!BN_copy(&(mont->N), mod))

        goto err;               /* Set N */

    if (BN_get_flags(mod, BN_FLG_CONSTTIME) != 0)

        BN_set_flags(&(mont->N), BN_FLG_CONSTTIME);

    mont->N.neg = 0;



#ifdef MONT_WORD