Commit 65c1f979 authored by Rich Salz's avatar Rich Salz
Browse files

Review comments; fail build if nits found 



Reviewed-by: default avatarRichard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/2202)
parent 29ee1be5

.gitignore

+1 −0
Original line number Diff line number Diff line
@@ -177,3 +177,4 @@ pod2htmd.tmp 


# Windows manifest files

*.manifest

doc-nits

.travis.yml

+2 −2
Original line number Diff line number Diff line
@@ -29,9 +29,9 @@ compiler: 
    - gcc



env:

    - CONFIG_OPTS="" DESTDIR="_install" CHECKDOCS="yes"

    - CONFIG_OPTS="" DESTDIR="_install"

    - CONFIG_OPTS="--debug no-shared enable-crypto-mdebug enable-rc5 enable-md2"

    - CONFIG_OPTS="no-pic --strict-warnings" BUILDONLY="yes"

    - CONFIG_OPTS="no-pic --strict-warnings" BUILDONLY="yes" CHECKDOCS="yes"

    - CONFIG_OPTS="no-engine no-shared --strict-warnings" BUILDONLY="yes"

    - CONFIG_OPTS="no-stdio --strict-warnings" BUILDONLY="yes"

Configurations/unix-Makefile.tmpl

+4 −3
Original line number Diff line number Diff line
@@ -323,9 +323,6 @@ install_sw: all install_dev install_engines install_runtime 


uninstall_sw: uninstall_runtime uninstall_engines uninstall_dev



doc-nits:

	$(PERL) util/find-doc-nits.pl -n



install_docs: install_man_docs install_html_docs



uninstall_docs: uninstall_man_docs uninstall_html_docs
@@ -677,6 +674,10 @@ update: generate errors ordinals 
generate: generate_apps generate_crypto_bn generate_crypto_objects \

          generate_crypto_conf generate_crypto_asn1



doc-nits:

	(cd $(SRCDIR); $(PERL) util/find-doc-nits.pl -n ) >doc-nits

	if [ -s doc-nits ] ; then cat doc-nits; exit 1; fi



# Test coverage is a good idea for the future

#coverage: $(PROGRAMS) $(TESTPROGRAMS)

#	...