Commit 511190b6 authored by Matt Caswell's avatar Matt Caswell
Browse files

Fix undefined behaviour in X509_NAME_cmp() 



If the lengths of both names is 0 then don't attempt to do a memcmp.

Issue reported by Simon Friedberger, Robert Merget and Juraj Somorovsky.

Reviewed-by: default avatarMatthias St. Pierre <Matthias.St.Pierre@ncp-e.com>
(Merged from https://github.com/openssl/openssl/pull/6291)
parent 246bd8fd

crypto/x509/x509_cmp.c

+1 −1
Original line number Diff line number Diff line
@@ -173,7 +173,7 @@ int X509_NAME_cmp(const X509_NAME *a, const X509_NAME *b) 


    ret = a->canon_enclen - b->canon_enclen;



    if (ret)

    if (ret != 0 || a->canon_enclen == 0)

        return ret;



    return memcmp(a->canon_enc, b->canon_enc, a->canon_enclen);