Commit 412bafdc authored by Rich Salz's avatar Rich Salz Committed by Rich Salz
Browse files

GH715: Missed some null-check-removals. 



Reviewed-by: default avatarRichard Levitte <levitte@openssl.org>
parent 91a61513

crypto/rsa/rsa_lib.c

+3 −6
Original line number Diff line number Diff line
@@ -154,7 +154,6 @@ RSA *RSA_new_method(ENGINE *engine) 
    ret->flags = ret->meth->flags & ~RSA_FLAG_NON_FIPS_ALLOW;

    if (!CRYPTO_new_ex_data(CRYPTO_EX_INDEX_RSA, ret, &ret->ex_data)) {

#ifndef OPENSSL_NO_ENGINE

        if (ret->engine)

        ENGINE_finish(ret->engine);

#endif

        OPENSSL_free(ret);
@@ -163,7 +162,6 @@ RSA *RSA_new_method(ENGINE *engine) 


    if ((ret->meth->init != NULL) && !ret->meth->init(ret)) {

#ifndef OPENSSL_NO_ENGINE

        if (ret->engine)

        ENGINE_finish(ret->engine);

#endif

        CRYPTO_free_ex_data(CRYPTO_EX_INDEX_RSA, ret, &ret->ex_data);
@@ -189,7 +187,6 @@ void RSA_free(RSA *r) 
    if (r->meth->finish)

        r->meth->finish(r);

#ifndef OPENSSL_NO_ENGINE

    if (r->engine)

    ENGINE_finish(r->engine);

#endif