Commit 394f7b6f authored by Emilia Kasper's avatar Emilia Kasper
Browse files

RT4002: check for NULL cipher in p12_crpt.c 



The NULL cipher case can't actually happen because we have no
EVP_PBE_CTL combinations where cipher_nid is -1 and keygen is
PKCS12_PBE_keyivgen. But make the code more obviously correct.

Reviewed-by: default avatarMatt Caswell <matt@openssl.org>
parent 25d6b340

crypto/pkcs12/p12_crpt.c

+3 −0
Original line number Diff line number Diff line
@@ -76,6 +76,9 @@ int PKCS12_PBE_keyivgen(EVP_CIPHER_CTX *ctx, const char *pass, int passlen, 
    unsigned char *salt;

    unsigned char key[EVP_MAX_KEY_LENGTH], iv[EVP_MAX_IV_LENGTH];



    if (cipher == NULL)

        return 0;



    /* Extract useful info from parameter */



    pbe = ASN1_TYPE_unpack_sequence(ASN1_ITEM_rptr(PBEPARAM), param);