From ade3822885d927404c727bce6a17d2b5ebabe0b3 Mon Sep 17 00:00:00 2001 From: kzangeli Date: Wed, 3 Jun 2026 21:57:42 +0200 Subject: [PATCH] fix(distops): Wait For Request must precede Get Request Url Params MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Six batch tests call `Get Request Url Params` to assert the forwarded ?options= mode, but HttpCtrl only populates the inspected request via `Wait For Request` — without it `self.__request` is None and the keyword crashes with "AttributeError: 'NoneType' object has no attribute 'get_url'" (stub replies don't populate it). D013_02_exc / D013_02_red had the Wait AFTER the params call — moved up (one Wait pops one request, so it must come first and serve both the params check and the later Get Request Body). D013_02_inc / D014_02_exc / D014_02_inc / D014_02_red had no Wait at all — inserted `Wait for redirected request` before the params call, matching the pattern D003_02_* already use. --- .../BatchEntities/UpdateBatchOfEntities/D014_02_exc.robot | 1 + .../BatchEntities/UpdateBatchOfEntities/D014_02_inc.robot | 1 + .../BatchEntities/UpdateBatchOfEntities/D014_02_red.robot | 1 + .../BatchEntities/UpsertBatchOfEntities/D013_02_exc.robot | 2 +- .../BatchEntities/UpsertBatchOfEntities/D013_02_inc.robot | 1 + .../BatchEntities/UpsertBatchOfEntities/D013_02_red.robot | 2 +- 6 files changed, 6 insertions(+), 2 deletions(-) diff --git a/TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpdateBatchOfEntities/D014_02_exc.robot b/TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpdateBatchOfEntities/D014_02_exc.robot index c41048db..aa4474a8 100644 --- a/TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpdateBatchOfEntities/D014_02_exc.robot +++ b/TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpdateBatchOfEntities/D014_02_exc.robot @@ -31,6 +31,7 @@ D014_02_exc Update Batch Entities with noOverwrite Option ${response}= Batch Update Entities @{entities_to_be_updated} overwrite_option=noOverwrite Check Response Status Code 204 ${response.status_code} + Wait for redirected request ${stub}= Get Request Url Params options Should Contain ${stub} noOverwrite diff --git a/TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpdateBatchOfEntities/D014_02_inc.robot b/TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpdateBatchOfEntities/D014_02_inc.robot index 11b0f670..7ed4e565 100644 --- a/TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpdateBatchOfEntities/D014_02_inc.robot +++ b/TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpdateBatchOfEntities/D014_02_inc.robot @@ -33,6 +33,7 @@ D014_02_inc Update Batch Entities With The noOverwrite Option ${response}= Batch Update Entities @{entities_to_be_updated} overwrite_option=noOverwrite Check Response Status Code 204 ${response.status_code} + Wait for redirected request ${stub}= Get Request Url Params options Should Contain ${stub} noOverwrite diff --git a/TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpdateBatchOfEntities/D014_02_red.robot b/TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpdateBatchOfEntities/D014_02_red.robot index 0735eada..eb0caea0 100644 --- a/TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpdateBatchOfEntities/D014_02_red.robot +++ b/TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpdateBatchOfEntities/D014_02_red.robot @@ -33,6 +33,7 @@ D014_02_red Update Batch Entities With noOverwrite Option ${response}= Batch Update Entities @{entities_to_be_updated} overwrite_option=noOverwrite Check Response Status Code 204 ${response.status_code} + Wait for redirected request ${stub}= Get Request Url Params options Should Contain ${stub} noOverwrite diff --git a/TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpsertBatchOfEntities/D013_02_exc.robot b/TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpsertBatchOfEntities/D013_02_exc.robot index 9164cffe..8a47eb26 100644 --- a/TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpsertBatchOfEntities/D013_02_exc.robot +++ b/TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpsertBatchOfEntities/D013_02_exc.robot @@ -34,10 +34,10 @@ D013_02_exc Batch Upsert Entities With Exclusive Registration With Update Flag ${response}= Batch Upsert Entities @{entities_to_be_upserted} update_option=update Check Response Status Code 204 ${response.status_code} + Wait for redirected request ${stub}= Get Request Url Params options Should Contain ${stub} update - Wait for redirected request ${request_payload}= Get Request Body ${payload}= Evaluate json.loads('''${request_payload}''') json Should Contain ${payload} ${new_first_entity} diff --git a/TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpsertBatchOfEntities/D013_02_inc.robot b/TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpsertBatchOfEntities/D013_02_inc.robot index 185e8dc4..b830eb24 100644 --- a/TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpsertBatchOfEntities/D013_02_inc.robot +++ b/TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpsertBatchOfEntities/D013_02_inc.robot @@ -34,6 +34,7 @@ D013_02_inc Batch Upsert Entities With Inclusive Registration With Update Flag ${response}= Batch Upsert Entities @{entities_to_be_upserted} update_option=update Check Response Status Code 204 ${response.status_code} + Wait for redirected request ${stub}= Get Request Url Params options Should Contain ${stub} update diff --git a/TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpsertBatchOfEntities/D013_02_red.robot b/TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpsertBatchOfEntities/D013_02_red.robot index 2ef07cd7..4f27c0a7 100644 --- a/TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpsertBatchOfEntities/D013_02_red.robot +++ b/TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpsertBatchOfEntities/D013_02_red.robot @@ -35,10 +35,10 @@ D013_02_red Batch Upsert Entities With Redirect Registration With Update Flag ${response}= Batch Upsert Entities @{entities_to_be_upserted} update_option=update Check Response Status Code 204 ${response.status_code} + Wait for redirected request ${stub}= Get Request Url Params options Should Contain ${stub} update - Wait for redirected request ${request_payload}= Get Request Body ${payload}= Evaluate json.loads('''${request_payload}''') json Should Contain ${payload} ${new_first_entity} -- GitLab