Commit c5bdeebe authored by Houcem Kacem's avatar Houcem Kacem
Browse files

refactor: remove unused variables and libraries in test cases + refactor Batch... 

refactor: remove unused variables and libraries in test cases + refactor Batch Request Entities From File keyword
parent 302d09ee

TP/NGSI-LD/ContextInformation/Provision/BatchEntities/CreateBatchOfEntities/failure.robot

+2 −5
Original line number Diff line number Diff line
@@ -2,16 +2,13 @@ 
Documentation   Check that you cannot create a batch of entities with an invalid request

Resource    ${EXECDIR}/resources/ApiUtils.resource

Resource    ${EXECDIR}/resources/AssertionUtils.resource

Library     RequestsLibrary

Library     JSONLibrary

Library     OperatingSystem



*** Test Case ***

With invalid json document

    [Documentation]  Check that you cannot create a batch of entities with an invalid json document

    [Tags]  mandatory



    Batch Request Entities From File   batch/invalid-json-sample.jsonld

    Batch Request Entities From File   create   filename=batch/invalid-json-sample.jsonld



    Check RL Response Status Code Set To  400

    Check RL Response Body Containing Problem Details Element Containing Detail Element    ${response}
@@ -20,7 +17,7 @@ With empty json document 
    [Documentation]  Check that you cannot create a batch of entities with an empty json document

    [Tags]  mandatory



    Batch Request Entities From File   batch/empty-sample.jsonld

    Batch Request Entities From File   create   filename=batch/empty-sample.jsonld



    Check RL Response Status Code Set To  400

    Check RL Response Body Containing Problem Details Element Containing Detail Element    ${response}

TP/NGSI-LD/ContextInformation/Provision/BatchEntities/CreateBatchOfEntities/fullSuccess.robot

+0 −3
Original line number Diff line number Diff line
@@ -3,9 +3,6 @@ Documentation Check that you can create a batch of entities 
Resource    ${EXECDIR}/resources/ApiUtils.resource

Resource    ${EXECDIR}/resources/AssertionUtils.resource

Resource    ${EXECDIR}/resources/JsonUtils.resource

Library     JSONLibrary

Library     String

Library     Collections



Test Template  Create Batch Entity Scenarios

TP/NGSI-LD/ContextInformation/Provision/BatchEntities/CreateBatchOfEntities/partialSuccess.robot

+0 −3
Original line number Diff line number Diff line
@@ -3,9 +3,6 @@ Documentation Check that you can create a batch of entities where some will su 
Resource    ${EXECDIR}/resources/ApiUtils.resource

Resource    ${EXECDIR}/resources/AssertionUtils.resource

Resource    ${EXECDIR}/resources/JsonUtils.resource

Library     JSONLibrary

Library     String

Library     Collections



Suite Setup      Setup Initial Entities

TP/NGSI-LD/ContextInformation/Provision/BatchEntities/DeleteBatchOfEntities/failure.robot

+2 −11
Original line number Diff line number Diff line 
*** Settings ***

Documentation   Check that you cannot delete a batch of entities with an invalid request

Variables   ${EXECDIR}/resources/variables.py

Resource    ${EXECDIR}/resources/ApiUtils.resource

Resource    ${EXECDIR}/resources/AssertionUtils.resource

Library     RequestsLibrary

Library     JSONLibrary

Library     OperatingSystem





*** Variable ***

${batch_endpoint}=    entityOperations/delete

${endpoint}=    entities



*** Test Case ***

With invalid json document

    [Documentation]  Check that you cannot delete a batch of entities with an invalid json document

    [Tags]  mandatory



    Batch Request Entities From File   batch/invalid-json-sample.jsonld

    Batch Request Entities From File   delete   filename=batch/invalid-json-sample.jsonld



    Check RL Response Status Code Set To  400

    Check RL Response Body Containing Problem Details Element Containing Detail Element    ${response}
@@ -26,7 +17,7 @@ With empty json document 
    [Documentation]  Check that you cannot delete a batch of entities with an empty json document

    [Tags]  mandatory



    Batch Request Entities From File   batch/empty-sample.jsonld

    Batch Request Entities From File   delete   filename=batch/empty-sample.jsonld



    Check RL Response Status Code Set To  400

    Check RL Response Body Containing Problem Details Element Containing Detail Element    ${response}

TP/NGSI-LD/ContextInformation/Provision/BatchEntities/DeleteBatchOfEntities/fullSuccess.robot

+0 −7
Original line number Diff line number Diff line 
*** Settings ***

Documentation   Check that you can delete a batch of entities

Variables   ${EXECDIR}/resources/variables.py

Resource    ${EXECDIR}/resources/ApiUtils.resource

Resource    ${EXECDIR}/resources/AssertionUtils.resource

Resource    ${EXECDIR}/resources/JsonUtils.resource

Library     REST    ${url}

Library     JSONLibrary

Library     String

Library     Collections



Suite Setup      Setup Initial Entities



*** Variable ***

${batch_delete_endpoint}=    entityOperations/delete

${endpoint}=    entities

${building_id_prefix}=  urn:ngsi-ld:Building:



*** Test Case ***