Commit c1624f44 authored by kzangeli's avatar kzangeli
Browse files

fix(discovery): 064_01 review - folder key RetrieveCSIdentity, no accept... 

fix(discovery): 064_01 review - folder key RetrieveCSIdentity, no accept argument, shorter documentation

Co-Authored-By: default avatarClaude Opus 5.5 <noreply@anthropic.com>
parent 3a1d35b4

TP/NGSI-LD/ContextSource/Discovery/RetrieveContextSourceIdentity/064_01.robot

+1 −1
Changes for TP/NGSI-LD/ContextSource/Discovery/RetrieveContextSourceIdentity/064_01.robot: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -7,7 +7,7 @@ Resource ${EXECDIR}/resources/AssertionUtils.resource 


*** Test Cases ***

064_01_01 Retrieve The Context Source Identity

    [Documentation]    Check that the Context Source identity has an id, its type, an alias, an uptime and the time at the Context Source

    [Documentation]    Check that the Context Source identity can be retrieved

    [Tags]    csi-retrieve    core_15_2    core_5_2_6_5_6    http_12_2_3_1

    ${response}=    Retrieve Context Source Identity

    Check Response Status Code    200    ${response.status_code}

doc/analysis/checks.py

+1 −2
Changes for doc/analysis/checks.py: 1 added line, 2 removed lines.
Original line number Diff line number Diff line
@@ -836,8 +836,7 @@ class Checks: 
    @staticmethod

    def check_response_body_containing_contextsourceidentity_element(kwargs: list) -> str:

        if 'response_body' in kwargs:

            return ("Response Body containing a ContextSourceIdentity element: id a URI, type 'ContextSourceIdentity', "

                    "contextSourceAlias not empty, contextSourceUptime a duration, contextSourceTimeAt a DateTime")

            return "Response Body containing a ContextSourceIdentity element"

        else:

            raise Exception(f"ERROR, expected response_body attribute, but received: {kwargs}")

doc/analysis/generaterobotdata.py

+1 −1
Changes for doc/analysis/generaterobotdata.py: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -93,7 +93,7 @@ class GenerateRobotData: 
            'RegistrationSubscription/CSRegistrationSubscriptionNotificationBehaviour': 'REGSUB',

            'RegistrationSUBBehaviour': 'REGSUB',

            'Discovery/RetrieveCSRegistration': 'DISC',

            'Discovery/RetrieveContextSourceIdentity': 'DISC',

            'Discovery/RetrieveCSIdentity': 'DISC',

            'Discovery/QueryCSRegistrations': 'DISC',

            'CommonResponses/VerifyLdContextNotAvailable': 'HTTP',

            'CommonResponses/VerifyMergePatchJson': 'HTTP',

doc/analysis/requests.py

+2 −5
Changes for doc/analysis/requests.py: 2 added lines, 5 removed lines.
Original line number Diff line number Diff line
@@ -92,7 +92,7 @@ class Requests: 
            },

            'Retrieve Context Source Identity': {

                'positions': [],

                'params': ['accept']

                'params': []

            },

            'Retrieve Entity Type': {

                'positions': [0, 1],
@@ -1355,10 +1355,7 @@ class Requests: 


    @staticmethod

    def retrieve_context_source_identity(kwargs) -> str:

        response = "Retrieve Context Source Identity"

        if 'accept' in kwargs and kwargs['accept'] not in ('', '${EMPTY}'):

            response = f"{response}, with Header['Accept'] set to '{kwargs['accept']}'"

        return response

        return "Retrieve Context Source Identity"



    @staticmethod

    def retrieve_attribute(kwargs) -> str:

resources/ApiUtils/ContextSourceDiscovery.resource

+0 −4
Changes for resources/ApiUtils/ContextSourceDiscovery.resource: 0 added lines, 4 removed lines.
Original line number Diff line number Diff line
@@ -166,13 +166,9 @@ Retrieve Context Source Registration 
Retrieve Context Source Identity

    [Documentation]    GET /info/sourceIdentity

    [Tags]    actor_context-consumer

    [Arguments]    ${accept}=${EMPTY}



    &{headers}=    Create Dictionary

    IF    '${accept}'!=''    Set To Dictionary    ${headers}    Accept=${accept}

    ${response}=    GET

    ...    url=${url}${NGSI_LD_API_PATH}/info/sourceIdentity

    ...    headers=${headers}

    ...    expected_status=any

    Output    ${response}    Retrieve Context Source Identity

    RETURN    ${response}