Commit ade38228 authored by kzangeli's avatar kzangeli
Browse files

fix(distops): Wait For Request must precede Get Request Url Params 

Six batch tests call `Get Request Url Params` to assert the forwarded
?options= mode, but HttpCtrl only populates the inspected request via
`Wait For Request` — without it `self.__request` is None and the keyword
crashes with "AttributeError: 'NoneType' object has no attribute
'get_url'" (stub replies don't populate it).

D013_02_exc / D013_02_red had the Wait AFTER the params call — moved up
(one Wait pops one request, so it must come first and serve both the
params check and the later Get Request Body). D013_02_inc /
D014_02_exc / D014_02_inc / D014_02_red had no Wait at all — inserted
`Wait for redirected request` before the params call, matching the
pattern D003_02_* already use.
parent 59eca008

TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpdateBatchOfEntities/D014_02_exc.robot

+1 −0
Original line number Diff line number Diff line
@@ -31,6 +31,7 @@ D014_02_exc Update Batch Entities with noOverwrite Option 
    ${response}=    Batch Update Entities    @{entities_to_be_updated}    overwrite_option=noOverwrite

    Check Response Status Code    204    ${response.status_code}



    Wait for redirected request

    ${stub}=    Get Request Url Params    options

    Should Contain    ${stub}    noOverwrite

TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpdateBatchOfEntities/D014_02_inc.robot

+1 −0
Original line number Diff line number Diff line
@@ -33,6 +33,7 @@ D014_02_inc Update Batch Entities With The noOverwrite Option 
    ${response}=    Batch Update Entities    @{entities_to_be_updated}    overwrite_option=noOverwrite

    Check Response Status Code    204    ${response.status_code}



    Wait for redirected request

    ${stub}=    Get Request Url Params    options

    Should Contain    ${stub}    noOverwrite

TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpdateBatchOfEntities/D014_02_red.robot

+1 −0
Original line number Diff line number Diff line
@@ -33,6 +33,7 @@ D014_02_red Update Batch Entities With noOverwrite Option 
    ${response}=    Batch Update Entities    @{entities_to_be_updated}    overwrite_option=noOverwrite

    Check Response Status Code    204    ${response.status_code}



    Wait for redirected request

    ${stub}=    Get Request Url Params    options

    Should Contain    ${stub}    noOverwrite

TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpsertBatchOfEntities/D013_02_exc.robot

+1 −1
Original line number Diff line number Diff line
@@ -34,10 +34,10 @@ D013_02_exc Batch Upsert Entities With Exclusive Registration With Update Flag 
    ${response}=    Batch Upsert Entities    @{entities_to_be_upserted}    update_option=update

    Check Response Status Code    204    ${response.status_code}



    Wait for redirected request

    ${stub}=    Get Request Url Params    options

    Should Contain    ${stub}    update



    Wait for redirected request

    ${request_payload}=    Get Request Body

    ${payload}=    Evaluate    json.loads('''${request_payload}''')    json

    Should Contain    ${payload}    ${new_first_entity}

TP/NGSI-LD/DistributedOperations/Provision/BatchEntities/UpsertBatchOfEntities/D013_02_inc.robot

+1 −0
Original line number Diff line number Diff line
@@ -34,6 +34,7 @@ D013_02_inc Batch Upsert Entities With Inclusive Registration With Update Flag 
    ${response}=    Batch Upsert Entities    @{entities_to_be_upserted}    update_option=update

    Check Response Status Code    204    ${response.status_code}



    Wait for redirected request

    ${stub}=    Get Request Url Params    options

    Should Contain    ${stub}    update