Commit 3c2d81a9 authored by kzangeli's avatar kzangeli
Browse files

refactor: rename `Wait for notification and validate it` → `Wait for CSource... 


refactor: rename `Wait for notification and validate it` → `Wait for CSource notification and validate it`

Addresses review comment on this MR (Benoît Orihuela): the keyword is
CSource-specific (asserts `type=ContextSourceNotification`), so the
unqualified name was confusing — it does not work for notifications from
a regular subscription. Renames the keyword definition in
`resources/NotificationUtils.resource` plus all 12 callers in
`TP/NGSI-LD/ContextSource/.../047_*.robot`.

Co-Authored-By: default avatarClaude Opus 4.7 <noreply@anthropic.com>
parent d1506289

TP/NGSI-LD/ContextSource/RegistrationSubscription/ContextSourceRegistrationSubscriptionNotificationBehaviour/047_02.robot

+2 −2
Original line number Diff line number Diff line
@@ -24,7 +24,7 @@ ${update_fragment_file_path}= csourceRegistrations/fra 
    [Tags]    csrsub-notification    5_11_7

    ${update_fragment}=    Load Test Sample    ${update_fragment_file_path}

    ${response}=    Update Context Source Registration    ${context_source_registration_id}    ${update_fragment}

    Wait for notification and validate it

    Wait for CSource notification and validate it

    ...    expected_subscription_id=${subscription_id}

    ...    expected_context_source_registration_ids=${expected_context_source_registration_ids}

    ...    expected_trigger_reason=updated
@@ -53,7 +53,7 @@ Create Initial Context Source Registration and Context Source Registration Subsc 
    Check Response Status Code    201    ${create_csrsub_response.status_code}

    @{expected_context_source_registration_ids}=    Create List    ${context_source_registration_id}

    Set Suite Variable    ${expected_context_source_registration_ids}

    Wait for notification and validate it

    Wait for CSource notification and validate it

    ...    expected_subscription_id=${subscription_id}

    ...    expected_context_source_registration_ids=${expected_context_source_registration_ids}

    ...    expected_trigger_reason=newlyMatching

TP/NGSI-LD/ContextSource/RegistrationSubscription/ContextSourceRegistrationSubscriptionNotificationBehaviour/047_03.robot

+1 −1
Original line number Diff line number Diff line
@@ -29,7 +29,7 @@ ${subscription_payload_file_path}= csourceSubscriptions/sub 
    ${response}=    Create Context Source Registration    ${context_source_registration_payload}

    @{expected_context_source_registration_ids}=    Create List    ${context_source_registration_id}

    @{expected_notification_data_entities}=    Create List    Building

    Wait for notification and validate it

    Wait for CSource notification and validate it

    ...    expected_subscription_id=${subscription_id}

    ...    expected_context_source_registration_ids=${expected_context_source_registration_ids}

    ...    expected_trigger_reason=newlyMatching

TP/NGSI-LD/ContextSource/RegistrationSubscription/ContextSourceRegistrationSubscriptionNotificationBehaviour/047_04.robot

+1 −1
Original line number Diff line number Diff line
@@ -28,7 +28,7 @@ ${subscription_payload_file_path}= csourceSubscriptions/sub 
    Set Suite Variable    ${context_source_registration_id}

    ${response}=    Create Context Source Registration    ${context_source_registration_payload}

    @{expected_context_source_registration_ids}=    Create List    ${context_source_registration_id}

    Wait for notification and validate it

    Wait for CSource notification and validate it

    ...    expected_subscription_id=${subscription_id}

    ...    expected_context_source_registration_ids=${expected_context_source_registration_ids}

    ...    expected_trigger_reason=newlyMatching

TP/NGSI-LD/ContextSource/RegistrationSubscription/ContextSourceRegistrationSubscriptionNotificationBehaviour/047_08.robot

+1 −1
Original line number Diff line number Diff line
@@ -25,7 +25,7 @@ ${update_fragment_file_path}= csourceRegistrations/fra 
    ${update_fragment}=    Load Test Sample    ${update_fragment_file_path}

    ${response}=    Update Context Source Registration    ${context_source_registration_id}    ${update_fragment}

    @{expected_context_source_registration_ids}=    Create List    ${context_source_registration_id}

    Wait for notification and validate it

    Wait for CSource notification and validate it

    ...    expected_subscription_id=${subscription_id}

    ...    expected_context_source_registration_ids=${expected_context_source_registration_ids}

    ...    expected_trigger_reason=updated

TP/NGSI-LD/ContextSource/RegistrationSubscription/ContextSourceRegistrationSubscriptionNotificationBehaviour/047_09.robot

+1 −1
Original line number Diff line number Diff line
@@ -25,7 +25,7 @@ ${update_fragment_file_path}= csourceRegistrations/fra 
    ${update_fragment}=    Load Test Sample    ${update_fragment_file_path}

    ${response}=    Update Context Source Registration    ${context_source_registration_id}    ${update_fragment}

    @{expected_context_source_registration_ids}=    Create List    ${context_source_registration_id}

    Wait for notification and validate it

    Wait for CSource notification and validate it

    ...    expected_subscription_id=${subscription_id}

    ...    expected_context_source_registration_ids=${expected_context_source_registration_ids}

    ...    expected_trigger_reason=noLongerMatching