Unverified Commit 3497ff9a authored by Benoit Orihuela's avatar Benoit Orihuela
Browse files

fix: handle PR comments

parent 7308b938

TP/NGSI-LD/ContextInformation/Consumption/Entity/QueryEntities/019_02_08.robot

+2 −3
Changes for TP/NGSI-LD/ContextInformation/Consumption/Entity/QueryEntities/019_02_08.robot: 2 added lines, 3 removed lines.
Original line number Diff line number Diff line
@@ -13,7 +13,7 @@ Test Template Query entities via POST based on q on a JsonProperty 




*** Test Cases ***    Q    JSON_KEYS    EXPECTED_COUNT

019_02_08_01 QueryOnNameEquality

019_02_08_01 QueryOnJsonPropertyIdEqual

    [Tags]    e-query    5_7_2    4_5_24    since_v1.8.1

    jsonProperty[id]=="some-id"    jsonProperty    1

019_02_08_02 QueryOnJsonPropertyTypeEqual
@@ -35,10 +35,9 @@ Query entities via POST based on q on a JsonProperty 
    [Documentation]    Check that one can query entities via POST based on q on a JsonProperty

    [Arguments]    ${q}    ${json_keys}    ${expected_count}



    @{json_keys_list}=    Create List    ${json_keys}

    ${response}=    Query Entities Via POST

    ...    q=${q}

    ...    jsonKeys=@{json_keys_list}

    ...    jsonKeys=${json_keys}

    ...    count=true

    ...    context=${ngsild_test_suite_context}

TP/NGSI-LD/ContextInformation/Consumption/Entity/QueryEntities/019_02_09.robot

+7 −8
Changes for TP/NGSI-LD/ContextInformation/Consumption/Entity/QueryEntities/019_02_09.robot: 7 added lines, 8 removed lines.
Original line number Diff line number Diff line
@@ -23,13 +23,13 @@ ${SIGHTSEEING_URI} https://uri.etsi.org/ngsi-ld/default-context/sightseeing 
# second entity: vocabProperty = ["monument", "sightseeing"] (array)

019_02_09_01 QueryWithExpandValuesEqualMonument

    [Tags]    e-query    5_7_2    4_5_20    since_v1.7.1

    vocabProperty==monument    vocabProperty    2

    vocabProperty=="monument"    vocabProperty    2

019_02_09_02 QueryWithExpandValuesEqualSightseeing

    [Tags]    e-query    5_7_2    4_5_20    since_v1.7.1

    vocabProperty==sightseeing    vocabProperty    1

019_02_09_03 QueryWithExpandValuesUnequalSightseeing

    vocabProperty=="sightseeing"    vocabProperty    1

019_02_09_03 QueryWithExpandValuesUnequalMonument

    [Tags]    e-query    5_7_2    4_5_20    since_v1.7.1

    vocabProperty!=monument    vocabProperty    1

    vocabProperty!="monument"    vocabProperty    0

019_02_09_04 QueryWithUriMonument

    [Tags]    e-query    5_7_2    4_5_20    since_v1.7.1

    vocabProperty=="${MONUMENT_URI}"    ${EMPTY}    2
@@ -38,10 +38,10 @@ ${SIGHTSEEING_URI} https://uri.etsi.org/ngsi-ld/default-context/sightseeing 
    vocabProperty=="${SIGHTSEEING_URI}"    ${EMPTY}    1

019_02_09_06 QueryWithExpandValuesValueListEqual

    [Tags]    e-query    5_7_2    4_5_20    since_v1.7.1

    vocabProperty==monument,sightseeing    vocabProperty    2

    vocabProperty=="monument","sightseeing"    vocabProperty    2

019_02_09_07 QueryWithExpandValuesValueListUnequal

    [Tags]    e-query    5_7_2    4_5_20    since_v1.7.1

    vocabProperty!=monument,sightseeing    vocabProperty    0

    vocabProperty!="monument","sightseeing"    vocabProperty    0

019_02_09_08 QueryWithUriValueList

    [Tags]    e-query    5_7_2    4_5_20    since_v1.7.1

    vocabProperty=="${MONUMENT_URI}","${SIGHTSEEING_URI}"    ${EMPTY}    2
@@ -52,10 +52,9 @@ Query entities via POST based on q on a VocabProperty 
    [Documentation]    Check that one can query entities based on q on a VocabProperty

    [Arguments]    ${q}    ${expand_values}    ${expected_count}



    @{expand_values_list}=    Create List    ${expand_values}

    ${response}=    Query Entities Via POST

    ...    q=${q}

    ...    expandValues=${expand_values_list}

    ...    expandValues=${expand_values}

    ...    count=true

    ...    context=${ngsild_test_suite_context}

TP/NGSI-LD/ContextInformation/Consumption/Entity/QueryEntities/019_09.robot

+1 −1
Changes for TP/NGSI-LD/ContextInformation/Consumption/Entity/QueryEntities/019_09.robot: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -58,7 +58,7 @@ ${entity_type}= https://ngsi-ld-test-suite/context#Building 
    locatedIn    1

019_09_14 QueryOnSubAttributeObservedAt

    [Tags]    e-query    5_7_2

    airQualityLevel.observedAt>="2021-01-01T00:00:00Z"    1

    airQualityLevel.observedAt>=2021-01-01T00:00:00Z    1

019_09_15 QueryOnAirQualityLevelValueListEqual

    [Tags]    e-query    5_7_2

    airQualityLevel==4,6    2

TP/NGSI-LD/ContextInformation/Consumption/Entity/QueryEntities/019_26.robot

+1 −1
Changes for TP/NGSI-LD/ContextInformation/Consumption/Entity/QueryEntities/019_26.robot: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -32,7 +32,7 @@ Test Template Query entities based on q on a LanguageProperty 
    street[*]!="SomeOtherValue"    2

019_26_06 QueryOnWildcardLanguageMatchPatternFrValue

    [Tags]    e-query    5_7_2    4_5_18    since_v1.6.1

    street[*]~=".*Place"    2

    street[*]~=.*Place    2





*** Keywords ***

TP/NGSI-LD/ContextInformation/Consumption/Entity/QueryEntities/019_28.robot

+6 −6
Changes for TP/NGSI-LD/ContextInformation/Consumption/Entity/QueryEntities/019_28.robot: 6 added lines, 6 removed lines.
Original line number Diff line number Diff line
@@ -23,13 +23,13 @@ ${SIGHTSEEING_URI}= https://uri.etsi.org/ngsi-ld/default-context/sightseeing 
# second entity: vocabProperty = ["monument", "sightseeing"] (array)

019_28_01 QueryWithExpandValuesEqualMonument

    [Tags]    e-query    5_7_2    4_5_20    since_v1.7.1

    vocabProperty==monument    vocabProperty    2

    vocabProperty=="monument"    vocabProperty    2

019_28_02 QueryWithExpandValuesEqualSightseeing

    [Tags]    e-query    5_7_2    4_5_20    since_v1.7.1

    vocabProperty==sightseeing    vocabProperty    1

019_28_03 QueryWithExpandValuesUnequalSightseeing

    vocabProperty=="sightseeing"    vocabProperty    1

019_28_03 QueryWithExpandValuesUnequalMonument

    [Tags]    e-query    5_7_2    4_5_20    since_v1.7.1

    vocabProperty!=monument    vocabProperty    1

    vocabProperty!="monument"    vocabProperty    0

019_28_04 QueryWithUriMonument

    [Tags]    e-query    5_7_2    4_5_20    since_v1.7.1

    vocabProperty=="${MONUMENT_URI}"    ${EMPTY}    2
@@ -38,10 +38,10 @@ ${SIGHTSEEING_URI}= https://uri.etsi.org/ngsi-ld/default-context/sightseeing 
    vocabProperty=="${SIGHTSEEING_URI}"    ${EMPTY}    1

019_28_06 QueryWithExpandValuesValueListEqual

    [Tags]    e-query    5_7_2    4_5_20    since_v1.7.1

    vocabProperty==monument,sightseeing    vocabProperty    2

    vocabProperty=="monument","sightseeing"    vocabProperty    2

019_28_07 QueryWithExpandValuesValueListUnequal

    [Tags]    e-query    5_7_2    4_5_20    since_v1.7.1

    vocabProperty!=monument,sightseeing    vocabProperty    0

    vocabProperty!="monument","sightseeing"    vocabProperty    0

019_28_08 QueryWithUriValueList

    [Tags]    e-query    5_7_2    4_5_20    since_v1.7.1

    vocabProperty=="${MONUMENT_URI}","${SIGHTSEEING_URI}"    ${EMPTY}    2