Commit fb260f5c authored by garciay's avatar garciay
Browse files

TODOs fixed

parent 89254826
Loading
Loading
Loading
Loading
+2 −2
Original line number Diff line number Diff line
@@ -79,7 +79,7 @@ module LibItsGeoNetworking_TestSystem {
        /**
         * @desc ITS Main Test Component
         */
        type component ItsMtc extends ItsBaseMtc, ServerSyncComp, ItsSecurityBaseComponent { // TODO Extend ItsBaseMtc with ItsSecurityBaseComponent? {
        type component ItsMtc extends ItsBaseMtc, ServerSyncComp, ItsSecurityBaseComponent { 
            
            port UpperTesterPort utPort;
            port AdapterControlPort acPort;
@@ -110,7 +110,7 @@ module LibItsGeoNetworking_TestSystem {
        
    } // End of group componentDefinitions
    
    type component ItsBaseGeoNetworking extends ItsBaseComponent, ItsSecurityBaseComponent { // TODO Extend ItsBaseComponent with ItsSecurityBaseComponent?
    type component ItsBaseGeoNetworking extends ItsBaseComponent, ItsSecurityBaseComponent { 
        
        port UpperTesterPort utPort;
        port AdapterControlPort acPort;
+1 −6
Original line number Diff line number Diff line
@@ -1022,9 +1022,6 @@ module LibItsGeoNetworking_TypesAndValues {
         * @member  startBeaconingMultipleNeighbour -
         * @member  stopBeaconingMultipleNeighbour  -
         * @member  getLongPosVector                -
// TODO To be removed
//         * @member  acEnableSecurity                -
//         * @member  acDisableSecurity               -
         */
        type union AcGnPrimitive {
            AcStartBeaconing startBeaconing,
@@ -1033,9 +1030,7 @@ module LibItsGeoNetworking_TypesAndValues {
            AcStopPassBeaconing stopPassBeaconing,
            AcStartBeaconingMultipleNeighbour startBeaconingMultipleNeighbour,
            AcStopBeaconingMultipleNeighbour stopBeaconingMultipleNeighbour,
            AcGetLongPosVector getLongPosVector/*, TODO To be removed
            AcEnableSecurity acEnableSecurity,
            AcDisableSecurity acDisableSecurity*/
            AcGetLongPosVector getLongPosVector
        }
        
        /**
+15 −15
Original line number Diff line number Diff line
@@ -131,11 +131,11 @@ module LibItsIvim_Templates {
            
            /**
             * @desc    Send template for Upper Tester Trigger event
             * @param   p_repetitionInterval        TODO (Default: 4 seconds)
             * @param   p_validFrom                 TODO (Default: omit)
             * @param   p_validTo                   TODO (Default: omit)
             * @param   p_connectedIviStructures    TODO (Default: omit)
             * @param   p_optional_                 TODO (Default: omit)
             * @param   p_repetitionInterval        Repetition interval (Default: 4 seconds)
             * @param   p_validFrom                 Valid From value (Default: omit)
             * @param   p_validTo                   Valid To value (Default: omit)
             * @param   p_connectedIviStructures    List of ConnectedIviStructure (Default: omit)
             * @param   p_optional_                 Optional field (Default: omit)
             */
            template (value) UtIvimTrigger m_utTriggerEvent(
                                                            template (omit) TimestampIts p_repetitionInterval := c_duration_4sec,
@@ -154,11 +154,11 @@ module LibItsIvim_Templates {
            /**
             * @desc Send template for Upper Tester event update
             * @param   p_iviIdentificationNumber   The p_iviIVI identification number
             * @param   p_timeStamp                 TODO (Default: 2 seconds)
             * @param   p_validFrom                 TODO (Default: omit)
             * @param   p_validTo                   TODO (Default: omit)
             * @param   p_connectedIviStructures    TODO (Default: omit)
             * @param   p_optional_                 TODO (Default: omit)
             * @param   p_timeStamp                 Time stamp value (Default: 2 seconds)
             * @param   p_validFrom                 Valid From value (Default: omit)
             * @param   p_validTo                   Valid To value (Default: omit)
             * @param   p_connectedIviStructures    List of ConnectedIviStructure (Default: omit)
             * @param   p_optional_                 Optional field (Default: omit)
             */
            template (value) UtIvimUpdate m_utUpdateEvent(
                                                          template (value) IviIdentificationNumber p_iviIdentificationNumber,
@@ -362,7 +362,7 @@ module LibItsIvim_Templates {
         * @param p_serviceProviderId       The IUT provider description
         * @param p_iviIdentificationNumber The IVIM identification number
         * @param p_iviStatus               The IVIM status
         * @param p_timeStamp               TODO
         * @param p_timeStamp               Time stamp value
         */
        template (present) IVIManagementContainer mw_iviManagementContainer_timestamp(
                                                                                      template (present) Provider p_serviceProviderId := ?, 
@@ -378,7 +378,7 @@ module LibItsIvim_Templates {
         * @param p_serviceProviderId       The IUT provider description
         * @param p_iviIdentificationNumber The IVIM identification number
         * @param p_iviStatus               The IVIM status
         * @param p_validTo                 TODO
         * @param p_validTo                 Valid To value
         */
        template (present) IVIManagementContainer mw_iviManagementContainer_validTo(
                                                                                    template (present) Provider p_serviceProviderId := ?, 
@@ -394,7 +394,7 @@ module LibItsIvim_Templates {
         * @param p_serviceProviderId       The IUT provider description
         * @param p_iviIdentificationNumber The IVIM identification number
         * @param p_iviStatus               The IVIM status
         * @param p_validFrom                 TODO
         * @param p_validFrom               Valid From value
         */
        template (present) IVIManagementContainer mw_iviManagementContainer_validFrom(
                                                                                      template (present) Provider p_serviceProviderId := ?, 
@@ -407,8 +407,8 @@ module LibItsIvim_Templates {
        
        /**
         * @desc Receive template for Porvide identifier
         * @param p_countryCode         TODO
         * @param p_providerIdentifier  TODO
         * @param p_countryCode         Country code value
         * @param p_providerIdentifier  Provider Identifier value
         */
        template (present) Provider mw_provider(
                                                template (present) CountryCode p_countryCode := ?,
+1 −1
Original line number Diff line number Diff line
@@ -148,7 +148,7 @@ module LibItsIpv6OverGeoNetworking_Functions {
                    ?,
                    ?,
                    c_macBroadcastAddr,
                    ? // TODO: rtAdv
                    ? // Refine rtAdv
                )
            )  {
                log("*** " & testcasename() & ": INFO: Ignoring Router Advertisement ***");   
+1 −1
Original line number Diff line number Diff line
@@ -170,7 +170,7 @@ module LibItsIpv6OverGeoNetworking_TypesAndValues {
            const Ipv6Address c_unspecified := '00000000000000000000000000000000'O;
            
            //geographic
            const Bit7 c_itsGn6aslGeoAnycastID := '1111101'B; //TODO TDB by IANA
            const Bit7 c_itsGn6aslGeoAnycastID := '1111101'B; // TDB by IANA
        }//end group ipv6Address
               
        /**
Loading