Reduced TODOs. (7b62a785) · Commits · TTCN-3 Libraries / LibIms

ttcn/LibIms_Steps.ttcn

+1 −3

Original line number	Original line	Diff line number	Diff line
	@@ -1050,7 +1050,7 @@ module LibIms_Steps {
	function f_IMS_postamble_withDeRegistration(		function f_IMS_postamble_withDeRegistration(
	CSeq p_cSeq_s		CSeq p_cSeq_s
	) runs on ImsComponent {		) runs on ImsComponent {
	f_RemoveRegistration(p_cSeq_s); // TODO check if applicable for IMS		f_RemoveRegistration(p_cSeq_s);
	f_terminate_component();		f_terminate_component();
	}		}

	@@ -1296,8 +1296,6 @@ module LibIms_Steps {
	log("* " & testcasename() & ": FAIL: Timeout while waiting for message. *");		log("* " & testcasename() & ": FAIL: Timeout while waiting for message. *");
	setverdict(fail);		setverdict(fail);
	all timer.stop;		all timer.stop;
	// TODO check how to solve release of call
	// f_SendCANCEL(m_CANCEL_Request(vc_callId, vc_cSeq, vc_from, vc_cancel_To, vc_reqHostPort, vc_via )); // difference between registration state or transaction state
	vc_callId := vc_callIdReg;		vc_callId := vc_callIdReg;
	action("Please de-register");		action("Please de-register");
	f_IMS_awaitDeRegistration(p_to_user, p_qop);		f_IMS_awaitDeRegistration(p_to_user, p_qop);

ttcn/LibIms_Templates.ttcn

+22 −23

Original line number	Original line	Diff line number	Diff line
	@@ -119,7 +119,6 @@ module LibIms_Templates {
	headers := omit		headers := omit
	}		}

	// TODO STF471 check this
	template(present) SemicolonParam_List mw_semicolonParams_realm(		template(present) SemicolonParam_List mw_semicolonParams_realm(
	template charstring p_realm		template charstring p_realm
	) :=		) :=
	@@ -766,7 +765,7 @@ module LibIms_Templates {
	template(value) Incoming_communication_barring p_icb		template(value) Incoming_communication_barring p_icb
	) := {		) := {
	simservs := {		simservs := {
	attr := omit, // TODO:CR		attr := omit,
	absServiceGroup_list := {},		absServiceGroup_list := {},
	extensions := {		extensions := {
	elem_list := valueof(p_icb.attr)		elem_list := valueof(p_icb.attr)
	@@ -778,7 +777,7 @@ module LibIms_Templates {
	template(value) Outgoing_communication_barring p_ocb		template(value) Outgoing_communication_barring p_ocb
	) := {		) := {
	simservs := {		simservs := {
	attr := omit, // TODO:CR		attr := omit,
	absServiceGroup_list := {},		absServiceGroup_list := {},
	extensions := {		extensions := {
	elem_list := valueof(p_ocb.attr)		elem_list := valueof(p_ocb.attr)
	@@ -878,7 +877,7 @@ module LibIms_Templates {
	template(value) RuleType p_ruleType		template(value) RuleType p_ruleType
	) := {		) := {
	active := omit,		active := omit,
	attr := omit, // TODO:CR		attr := omit,
	ruleset := {		ruleset := {
	{p_ruleType}		{p_ruleType}
	}		}
	@@ -888,7 +887,7 @@ module LibIms_Templates {
	template(value) RuleType p_ruleType		template(value) RuleType p_ruleType
	) := {		) := {
	active := omit,		active := omit,
	attr := omit, // TODO:CR		attr := omit,
	ruleset := {		ruleset := {
	{p_ruleType}		{p_ruleType}
	}		}
	@@ -938,7 +937,7 @@ module LibIms_Templates {
	template(omit) TwobitType p_cci := omit		template(omit) TwobitType p_cci := omit
	) := {		) := {
	active := omit,		active := omit,
	attr := omit, // TODO:CR		attr := omit,
	cugCallOperation := p_crt,		cugCallOperation := p_crt,
	networkIndicator := p_nit,		networkIndicator := p_nit,
	cugInterlockBinaryCode := p_cibc,		cugInterlockBinaryCode := p_cibc,
	@@ -952,7 +951,7 @@ module LibIms_Templates {
	template TwobitType p_cci		template TwobitType p_cci
	) := {		) := {
	active := omit,		active := omit,
	attr := ?,		attr := *,
	cugCallOperation := p_crt,		cugCallOperation := p_crt,
	networkIndicator := p_nit,		networkIndicator := p_nit,
	cugInterlockBinaryCode := p_cibc,		cugInterlockBinaryCode := p_cibc,
	@@ -982,7 +981,7 @@ module LibIms_Templates {
	template(value) Ims_cw m_CW(		template(value) Ims_cw m_CW(
	template(value) TEmptyType p_cwi		template(value) TEmptyType p_cwi
	) := {		) := {
	attr := omit, // TODO:CR		attr := omit,
	communication_waiting_indication := p_cwi,		communication_waiting_indication := p_cwi,
	elem_list := {}		elem_list := {}
	}		}
	@@ -990,7 +989,7 @@ module LibIms_Templates {
	template(present) Ims_cw mw_ims_cw(		template(present) Ims_cw mw_ims_cw(
	template(present) TEmptyType p_cwi := ?		template(present) TEmptyType p_cwi := ?
	) := {		) := {
	attr := ?,		attr := *,
	communication_waiting_indication := p_cwi,		communication_waiting_indication := p_cwi,
	elem_list := ?		elem_list := ?
	}		}
	@@ -1090,8 +1089,8 @@ module LibIms_Templates {
	bearerInfomationElement_list := {p_bct, p_bct2},		bearerInfomationElement_list := {p_bct, p_bct2},
	highLayerCompatibility_list := {, },		highLayerCompatibility_list := {, },
	lowLayerCompatibility := *,		lowLayerCompatibility := *,
	progressIndicator_list := {*},		progressIndicator_list := *,
	display_list := {*}		display_list := *
	}		}

	template(value) PSTN_transit m_PSTN_transit_BC1_HLC1(		template(value) PSTN_transit m_PSTN_transit_BC1_HLC1(
	@@ -1323,9 +1322,9 @@ module LibIms_Templates {
	template(value) Comm_div_info_type m_CDIVN_sub := {		template(value) Comm_div_info_type m_CDIVN_sub := {
	entity := "comm-div-info",		entity := "comm-div-info",
	comm_div_subs_info := {		comm_div_subs_info := {
	attr := omit, // TODO:CR		attr := omit,
	comm_div_selection_criteria := {		comm_div_selection_criteria := {
	attr := omit, // TODO:CR		attr := omit,
	originating_user_selection_criteria := omit,		originating_user_selection_criteria := omit,
	diverting_user_selection_criteria := omit,		diverting_user_selection_criteria := omit,
	diverted_to_user_selection_criteria := omit,		diverted_to_user_selection_criteria := omit,
	@@ -1353,7 +1352,7 @@ module LibIms_Templates {
	{		{
	list := {		list := {
	name := omit,		name := omit,
	attr := omit, // TODO:CR		attr := omit,
	display_name := omit,		display_name := omit,
	sequence_list := {		sequence_list := {
	{		{
	@@ -1380,7 +1379,7 @@ module LibIms_Templates {
	p_user.components.sip.userInfo.userOrTelephoneSubscriber		p_user.components.sip.userInfo.userOrTelephoneSubscriber
	& "@"		& "@"
	& p_user.components.sip.hostPort.host,		& p_user.components.sip.hostPort.host,
	attr := omit, // TODO:CR		attr := omit,
	display_name := omit,		display_name := omit,
	elem_list := {}		elem_list := {}
	}		}
	@@ -1415,7 +1414,7 @@ module LibIms_Templates {
	template(value) Media_status_type p_status		template(value) Media_status_type p_status
	) := {		) := {
	id := "1",		id := "1",
	attr := omit, // TODO:CR		attr := omit,
	display_text := omit,		display_text := omit,
	type_ := omit,		type_ := omit,
	label_ := omit,		label_ := omit,
	@@ -1433,7 +1432,7 @@ module LibIms_Templates {
	) := {		) := {
	entity := p_Uri,		entity := p_Uri,
	state := full,		state := full,
	attr := omit, // TODO:CR		attr := omit,
	display_text := omit,		display_text := omit,
	referred := omit,		referred := omit,
	status := p_epStatus,		status := p_epStatus,
	@@ -1452,7 +1451,7 @@ module LibIms_Templates {
	) := {		) := {
	entity := p_Uri,		entity := p_Uri,
	state := full,		state := full,
	attr := omit, // TODO:CR		attr := omit,
	display_text := omit,		display_text := omit,
	associated_aors := omit,		associated_aors := omit,
	roles := omit,		roles := omit,
	@@ -1466,7 +1465,7 @@ module LibIms_Templates {
	template(value) User_type p_user		template(value) User_type p_user
	) := {		) := {
	state := full,		state := full,
	attr := omit, // TODO:CR		attr := omit,
	user_list := {p_user},		user_list := {p_user},
	elem_list := {}		elem_list := {}
	}		}
	@@ -1483,7 +1482,7 @@ module LibIms_Templates {
	template(value) boolean p_active,		template(value) boolean p_active,
	template(value) boolean p_locked		template(value) boolean p_locked
	) := {		) := {
	attr := omit, // TODO:CR		attr := omit,
	user_count := p_nUsers,		user_count := p_nUsers,
	active := p_active,		active := p_active,
	locked := p_locked,		locked := p_locked,
	@@ -1498,7 +1497,7 @@ module LibIms_Templates {
	entity := p_cUri,		entity := p_cUri,
	state := full,		state := full,
	version := 1,		version := 1,
	attr := omit, // TODO:CR		attr := omit,
	conference_description := omit,		conference_description := omit,
	host_info := omit,		host_info := omit,
	conference_state := p_cState,		conference_state := p_cState,
	@@ -1541,7 +1540,7 @@ module LibIms_Templates {
	joining_info := *,		joining_info := *,
	disconnection_method := *,		disconnection_method := *,
	disconnection_info := *,		disconnection_info := *,
	media_list := ?, // TODO:CR		media_list := *,
	call_info := *,		call_info := *,
	elem_list := ?		elem_list := ?
	}		}
	@@ -1549,7 +1548,7 @@ module LibIms_Templates {
	elem_list := ?		elem_list := ?
	}		}
	},		},
	elem_list := {}		elem_list := ?
	},		},
	sidebars_by_ref := *,		sidebars_by_ref := *,
	sidebars_by_val := *,		sidebars_by_val := *,

Admin message