Commit 3511a36b authored by pintar's avatar pintar
Browse files

check of TODOs

parent 66639269

ttcn/LibDiameter_Interface.ttcn

+9 −15
Original line number Original line Diff line number Diff line
@@ -27,12 +27,12 @@ module LibDiameter_Interface 
      port 	LowerLayerPPort LLPP;

      port 	LowerLayerPPort LLPP;

      port 	DiameterPort DIAMP;

      port 	DiameterPort DIAMP;

      

      

	  //TODO global variables have to be defined

	  //global variables

	  var charstring vc_ETS_address := ""; //TODO define PIXIT

	  var charstring vc_ETS_address := ""; 		//defined in init

      var integer vc_ETS_port		:= 0;  //TODO define PIXIT

      var integer vc_ETS_port		:= 3868;  	//defined in init

      var charstring vc_SUT_address := ""; //TODO define PIXIT

      var charstring vc_SUT_address := ""; 		//defined in init

      var integer vc_SUT_port 		:= 0;  //TODO define PIXIT

      var integer vc_SUT_port 		:= 3868;  	//defined in init

      var integer vc_ETS_conn		:= 0;  //TODO make check if this global variable is zero than connection not available

      var integer vc_ETS_conn		:= 0;  //used if LLP primitives are in use

      var DIAMETER_MSG vc_sendDiamMsg ;

      var DIAMETER_MSG vc_sendDiamMsg ;

      var DIAMETER_MSG vc_recvDiamMsg ;

      var DIAMETER_MSG vc_recvDiamMsg ;

      var DIAMETER_MSG vc_recvDiamMsgDefault ; //global variable defined to save Dimeter message received within default altstep

      var DIAMETER_MSG vc_recvDiamMsgDefault ; //global variable defined to save Dimeter message received within default altstep
@@ -55,19 +55,13 @@ module LibDiameter_Interface 
      var template Result_Code_AVP vc_resultCode;

      var template Result_Code_AVP vc_resultCode;

      var template Media_Component_Description_AVP vc_mediaComponentDescription;

      var template Media_Component_Description_AVP vc_mediaComponentDescription;

        

        

      

      //general timers

      

      timer tc_wait  := 5.0;  //define PIXIT if needed

	    

      //TODO general timers have to be defined

      timer tc_wait  := 5.0;  //TODO define PIXIT if needed

  		

  		

      // variables for storing default references

      // variables for storing default references

	  var default 	vc_default_diameter;

	  var default 	vc_default_diameter;

	  var default 	vc_def_catchSyncStop_diameter;

	  var default 	vc_def_catchSyncStop_diameter;





      //TODO check if needed like in SIP      // ETS address

	  // var address v_ets_label := { host := PX_SIP_TS1_IPADDR, portField := PX_SIP_TS1_PORT};



      // parts needed for Client/SelfSyncComp type compatibility

      // parts needed for Client/SelfSyncComp type compatibility

      var 	StringStack v_stateStack := c_initStringStack;

      var 	StringStack v_stateStack := c_initStringStack;

      port 	SyncPort 	syncSendPort;

      port 	SyncPort 	syncSendPort;

ttcn/LibDiameter_Steps.ttcn

+1 −4
Original line number Original line Diff line number Diff line
@@ -68,7 +68,6 @@ group AwaitingMessage { 
            	[]DIAMP.receive	(p_diameterMSG) -> value v_MSG

            	[]DIAMP.receive	(p_diameterMSG) -> value v_MSG

            	  {

            	  {

            		tc_wait.stop;

            		tc_wait.stop;

            		//TODO store received params

            		vc_recvDiamMsg := v_MSG;

            		vc_recvDiamMsg := v_MSG;

            	  }

            	  }

    		}

    		}
@@ -81,7 +80,6 @@ group AwaitingMessage { 
                []DIAMP.receive	(p_diameterMSG) -> value v_MSG

                []DIAMP.receive	(p_diameterMSG) -> value v_MSG

                  {

                  {

                    tc_wait.stop;

                    tc_wait.stop;

                    //TODO store received params

                    vc_recvDiamMsg := v_MSG;

                    vc_recvDiamMsg := v_MSG;

                  }

                  }

            }

            }
@@ -823,7 +821,6 @@ group Postambles { 
                

                

        function f_postambleDiameterBase()runs on DiameterComponent

        function f_postambleDiameterBase()runs on DiameterComponent

        {

        {

            //TODO define templates

            f_send_DPR(m_DPR_basic(vc_originHost, vc_originRealm));

            f_send_DPR(m_DPR_basic(vc_originHost, vc_originRealm));

            f_awaiting_DPA(mw_DPA_dummy);

            f_awaiting_DPA(mw_DPA_dummy);