Bug 255

Summary:	SOL006 Jenkins build is broken
Product:	NFV	Reporter:	Mahesh Jethanandani <mjethanandan>
Component:	GS NFV-SOL 006 Yang model	Assignee:	Bruno Chatras <bruno.chatras>
Status:	CONFIRMED ---
Severity:	enhancement	CC:	michele.carignani
Priority:	Normal
Version:	2.7.1
Target Milestone:	---
Hardware:	PC
OS:	Windows
Version number of the related document:		OpenAPI issue category:	---

Description Mahesh Jethanandani 2019-10-07 22:25:35 CEST

The current Jenkins run is broken. The run fails as follows. However, it returns a status of SUCCESS. It turns out that the step "Loading Data for NSD" was indeed broken, and yes, there is no file call /yang/etsi-nfv.yang. So the build should have returned an error. I will fix the file responsible for loading the correct NSD data, but I need help from CTI on fixing why Jenkins is returning success.

21:32:24 Starting ConfD
21:32:27 Loading Data for VNFD
21:32:27 Loading Data for PNFD
21:32:27 Loading Data for NSD
21:32:27 confd_load: 666: maapi_load_config(sock, tid, flags, abspath(argv[0])) failed: external error (19): Error on line 2: unknown element: vnfd in /nsd:nsd/nsd:vnfd
21:32:27 
21:32:27 Building HTML tree
21:32:29 error /yang/etsi-nfv.yang: [Errno 2] No such file or directory: '/yang/etsi-nfv.yang'
21:32:29 Discard old builds...
21:32:29 #176 is removed because old than numToKeep
21:32:29 Finished: SUCCESS

Comment 1 Michele Carignani 2019-10-08 13:45:29 CEST

Hi Mahesh,

I agree that the current outcome is not truthful. We should agree on the definition of the outcome.

Should it be a logical AND of the outcome of the 2 docker run? 

Also regarding the first docker run command, is the outcome an AND of all the "confdc" and "confd_load" commands?

Comment 2 Mahesh Jethanandani 2019-10-08 20:03:37 CEST

Building of the HTML tree is a nice-to-have feature, and should not decide whether the model is correct or not. The compilation before the loading of data validates the model. Having said that, we should fix the building of the HTML tree.

I would suggest that the if the compilation (confdc) or loading (confd_load) fails, we fail the Jenkins build. Note, confdc might return warnings during compilation. Those are not errors, and only errors should result in a failure.