0006412: system component shall be passed to functions with map/unmap statements

ETSI's Bug Tracker - Part 01: TTCN-3 Core Language

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0006412

Part 01: TTCN-3 Core Language

Technical

public

16-01-2013 12:39

28-08-2013 14:59

Reporter

Thilo Lauer

Assigned To

Ina Schieferdecker

Priority

normal

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

v4.4.1 (published 2012-04)

Target Version

v4.6.1 (published 2014-06)

Fixed in Version

v4.6.1 (published 2014-06)

Clause Reference(s)

16.1 Functions

Source (company - Author)

Devoteam - Thilo Lauer

Summary

0006412: system component shall be passed to functions with map/unmap statements

Description

If map/unmap statements are used in a function, then the system component should also be passed to this function,
  (1) either as parameter
  (2) or by using keyword system to define the function's system component.

Let's assume the following component definitions:
  type component UTRAN_PTC {
    var UTRAN_Global_Type vc_UTRAN_Global;

    port UTRAN_AM_PORT U_AM;
    port UTRAN_TM_PORT U_TM;
    port UTRAN_UM_PORT U_UM;
    ...
    port UTRAN_VNG_PORT U_VNG;
    ...
  };

  type component UTRAN_SYSTEM {
    port UTRAN_AM_PORT S_U_AM;
    port UTRAN_TM_PORT S_U_TM;
    port UTRAN_UM_PORT S_U_UM;
    ...
    port UTRAN_VNG_PORT S_U_VNG;
  };

Example:
The defintition of function f_UTRAN_PTC_Map below can generally be called in the context of different test cases
with different system components (defining different system ports).
Therefore if this function is defined as shown below, it can currently not be decided at compile time
if the system component actually has the system ports used in the function's map statements:

  function f_UTRAN_PTC_Map(UTRAN_PTC p_Utran)
  {
    map(p_Utran:U_AM, system:S_U_AM);
    map(p_Utran:U_TM, system:S_U_TM);
    map(p_Utran:U_UM, system:S_U_UM);
    // ... further map statements

    if (f_GetTestcaseAttrib_Qbased_Rsrq(testcasename())) {
      map(p_Utran:U_VNG, system:S_U_VNG);
    }
  }

Given the function definition above, errors with system port mappings can only be detected at runtime.

To be able to do this checks at compile time, we suggest ...
============================================================
1.) either to pass the system component additionally as parameter:
    i.e. to change the function definition in the test suite to:

  function f_UTRAN_PTC_Map(UTRAN_PTC p_Utran, UTRAN_SYSTEM sys_Utran)
  // *** added parameter: UTRAN_SYSTEM sys_Utran ***
  {
    map(p_Utran:U_AM, sys_Utran:S_U_AM);
    map(p_Utran:U_TM, sys_Utran:S_U_TM);
    map(p_Utran:U_UM, sys_Utran:S_U_UM);
    // ... further map statements

    if (f_GetTestcaseAttrib_Qbased_Rsrq(testcasename())) {
      map(p_Utran:U_VNG, sys_Utran:S_U_VNG);
    }
  }

  // function call:
  f_UTRAN_PTC_Map(p_Utran, system);
  // *** keyword "system" passed as actual component parameter value here ***


2.) or to change the TTCN-3 syntax for function definitions as shown below:

  function f_UTRAN_PTC_Map(UTRAN_PTC p_Utran) system UTRAN_SYSTEM
  // *** system UTRAN_SYSTEM added ***
  {
    ...
  }

Solution 1.) requires a change in some ETSI/3GPP suites
Solution 2.) requires a change in some ETSI/3GPP suites and in the TTCN-3 standard as well.

Steps To Reproduce

Additional Information